Add Audita configuration contract

2026-05-04 07:48:59 -05:00
parent 1b8fb78926
commit fbc53330ef
8 changed files with 543 additions and 7 deletions
--- a/internal/app/commands_test.go
+++ b/internal/app/commands_test.go
@@ -216,7 +216,7 @@ seriatim:
  coalesce_gap: 3.0
  report: true
 audita:
-  timeout: 1h
+  binary: audita
 analyzer:
  timeout: 20m
  artifacts:
--- a/internal/config/config.go
+++ b/internal/config/config.go
@@ -70,9 +70,16 @@ type SeriatimEnvConfig struct {

 // AuditaConfig configures audita adapter settings.
 type AuditaConfig struct {
-	BinaryPath string   `yaml:"binary_path"`
-	Timeout    string   `yaml:"timeout"`
-	Args       []string `yaml:"args"`
+	Binary                   string   `yaml:"binary"`
+	Timeout                  string   `yaml:"timeout"`
+	LLMAPIKeyEnv             string   `yaml:"llm_api_key_env"`
+	Modules                  []string `yaml:"modules"`
+	BaseURL                  string   `yaml:"base_url"`
+	Model                    string   `yaml:"model"`
+	LLMConcurrency           *int     `yaml:"llm_concurrency"`
+	ValidationModel          string   `yaml:"validation_model"`
+	ValidationLLMConcurrency *int     `yaml:"validation_llm_concurrency"`
+	Report                   *bool    `yaml:"report"`
 }

 // AnalyzerConfig configures analyzer adapter settings.
--- a/internal/config/load.go
+++ b/internal/config/load.go
@@ -83,6 +83,7 @@ func applyPipelineDefaults(cfg *PipelineConfig) {
 	}
 	applyWhisperXDefaults(&cfg.WhisperX)
 	applySeriatimDefaults(&cfg.Seriatim)
+	applyAuditaDefaults(&cfg.Audita)
 }

 func applyWhisperXDefaults(cfg *WhisperXConfig) {
@@ -129,6 +130,44 @@ func applySeriatimDefaults(cfg *SeriatimConfig) {
 	}
 }

+func applyAuditaDefaults(cfg *AuditaConfig) {
+	if cfg == nil {
+		return
+	}
+	if cfg.Timeout == "" {
+		cfg.Timeout = "3h"
+	}
+	if cfg.LLMAPIKeyEnv == "" {
+		cfg.LLMAPIKeyEnv = "AUDITA_LLM_API_KEY"
+	}
+	if cfg.Modules == nil {
+		cfg.Modules = []string{
+			"glossary",
+			"homophones",
+			"glossary",
+			"spoken_word",
+			"grammar",
+			"homophones",
+			"glossary",
+		}
+	}
+	if cfg.BaseURL == "" {
+		cfg.BaseURL = "https://openrouter.ai/api/v1"
+	}
+	if cfg.Model == "" {
+		cfg.Model = "openrouter/google/gemma-4-31b-it"
+	}
+	if cfg.LLMConcurrency == nil {
+		cfg.LLMConcurrency = intPtr(1)
+	}
+	if cfg.ValidationLLMConcurrency == nil {
+		cfg.ValidationLLMConcurrency = intPtr(1)
+	}
+	if cfg.Report == nil {
+		cfg.Report = boolPtr(true)
+	}
+}
+
 func float64Ptr(v float64) *float64 {
 	p := v
 	return &p
--- a/internal/config/load_validate_test.go
+++ b/internal/config/load_validate_test.go
@@ -25,7 +25,7 @@ whisperx:
 seriatim:
  binary: seriatim
 audita:
-  timeout: 1h
+  binary: audita
 analyzer:
  timeout: 20m
 notification:
@@ -350,6 +350,219 @@ inputs:
 `,
 			wantValidate: "pipeline config \"pipeline.yml\" invalid: pipeline.seriatim.env.overlap_word_run_gap must be > 0 when provided",
 		},
+		{
+			name: "unknown audita field fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  transcribe_url: https://transcription.ai.rakestrawhome.com/transcribe
+seriatim:
+  binary: seriatim
+audita:
+  binary: audita
+  bogus: true
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantLoadErr: "strict decode failed",
+		},
+		{
+			name: "missing audita binary fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  transcribe_url: https://transcription.ai.rakestrawhome.com/transcribe
+seriatim:
+  binary: seriatim
+audita:
+  timeout: 3h
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantValidate: "pipeline config \"pipeline.yml\" invalid: pipeline.audita.binary is required",
+		},
+		{
+			name: "invalid audita timeout fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  transcribe_url: https://transcription.ai.rakestrawhome.com/transcribe
+seriatim:
+  binary: seriatim
+audita:
+  binary: audita
+  timeout: bad-timeout
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantValidate: "pipeline config \"pipeline.yml\" invalid: pipeline.audita.timeout must be a valid duration",
+		},
+		{
+			name: "empty audita llm_api_key_env fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  transcribe_url: https://transcription.ai.rakestrawhome.com/transcribe
+seriatim:
+  binary: seriatim
+audita:
+  binary: audita
+  llm_api_key_env: "   "
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantValidate: "pipeline config \"pipeline.yml\" invalid: pipeline.audita.llm_api_key_env is required",
+		},
+		{
+			name: "empty audita modules fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  transcribe_url: https://transcription.ai.rakestrawhome.com/transcribe
+seriatim:
+  binary: seriatim
+audita:
+  binary: audita
+  modules: []
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantValidate: "pipeline config \"pipeline.yml\" invalid: pipeline.audita.modules must include at least one module",
+		},
+		{
+			name: "empty audita module item fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  transcribe_url: https://transcription.ai.rakestrawhome.com/transcribe
+seriatim:
+  binary: seriatim
+audita:
+  binary: audita
+  modules:
+    - glossary
+    - ""
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantValidate: "pipeline config \"pipeline.yml\" invalid: pipeline.audita.modules[1] must be non-empty",
+		},
+		{
+			name: "invalid audita module item fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  transcribe_url: https://transcription.ai.rakestrawhome.com/transcribe
+seriatim:
+  binary: seriatim
+audita:
+  binary: audita
+  modules:
+    - glossary
+    - bad_module
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantValidate: "pipeline config \"pipeline.yml\" invalid: pipeline.audita.modules[1] must be one of: glossary, homophones, spoken_word, grammar",
+		},
+		{
+			name: "invalid audita base_url fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  transcribe_url: https://transcription.ai.rakestrawhome.com/transcribe
+seriatim:
+  binary: seriatim
+audita:
+  binary: audita
+  base_url: ://
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantValidate: "pipeline config \"pipeline.yml\" invalid: pipeline.audita.base_url must be a valid URL",
+		},
+		{
+			name: "invalid audita llm_concurrency fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  transcribe_url: https://transcription.ai.rakestrawhome.com/transcribe
+seriatim:
+  binary: seriatim
+audita:
+  binary: audita
+  llm_concurrency: 0
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantValidate: "pipeline config \"pipeline.yml\" invalid: pipeline.audita.llm_concurrency must be > 0",
+		},
+		{
+			name: "invalid audita validation_llm_concurrency fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  transcribe_url: https://transcription.ai.rakestrawhome.com/transcribe
+seriatim:
+  binary: seriatim
+audita:
+  binary: audita
+  validation_llm_concurrency: 0
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantValidate: "pipeline config \"pipeline.yml\" invalid: pipeline.audita.validation_llm_concurrency must be > 0",
+		},
 	}

 	for _, tt := range tests {
@@ -407,6 +620,33 @@ inputs:
 				if cfg.Pipeline.Seriatim.Report == nil || *cfg.Pipeline.Seriatim.Report != true {
 					t.Fatalf("seriatim.report = %v, want true", cfg.Pipeline.Seriatim.Report)
 				}
+				if cfg.Pipeline.Audita.Timeout != "3h" {
+					t.Fatalf("audita.timeout = %q, want %q", cfg.Pipeline.Audita.Timeout, "3h")
+				}
+				if cfg.Pipeline.Audita.LLMAPIKeyEnv != "AUDITA_LLM_API_KEY" {
+					t.Fatalf("audita.llm_api_key_env = %q, want %q", cfg.Pipeline.Audita.LLMAPIKeyEnv, "AUDITA_LLM_API_KEY")
+				}
+				if got := strings.Join(cfg.Pipeline.Audita.Modules, ","); got != "glossary,homophones,glossary,spoken_word,grammar,homophones,glossary" {
+					t.Fatalf("audita.modules = %q, want default sequence", got)
+				}
+				if cfg.Pipeline.Audita.BaseURL != "https://openrouter.ai/api/v1" {
+					t.Fatalf("audita.base_url = %q, want %q", cfg.Pipeline.Audita.BaseURL, "https://openrouter.ai/api/v1")
+				}
+				if cfg.Pipeline.Audita.Model != "openrouter/google/gemma-4-31b-it" {
+					t.Fatalf("audita.model = %q, want %q", cfg.Pipeline.Audita.Model, "openrouter/google/gemma-4-31b-it")
+				}
+				if cfg.Pipeline.Audita.LLMConcurrency == nil || *cfg.Pipeline.Audita.LLMConcurrency != 1 {
+					t.Fatalf("audita.llm_concurrency = %v, want 1", cfg.Pipeline.Audita.LLMConcurrency)
+				}
+				if cfg.Pipeline.Audita.ValidationModel != "" {
+					t.Fatalf("audita.validation_model = %q, want empty default", cfg.Pipeline.Audita.ValidationModel)
+				}
+				if cfg.Pipeline.Audita.ValidationLLMConcurrency == nil || *cfg.Pipeline.Audita.ValidationLLMConcurrency != 1 {
+					t.Fatalf("audita.validation_llm_concurrency = %v, want 1", cfg.Pipeline.Audita.ValidationLLMConcurrency)
+				}
+				if cfg.Pipeline.Audita.Report == nil || *cfg.Pipeline.Audita.Report != true {
+					t.Fatalf("audita.report = %v, want true", cfg.Pipeline.Audita.Report)
+				}
 			}

 			err = Validate(cfg)
@@ -447,6 +687,18 @@ func TestValidateMissingAudioSource(t *testing.T) {
 				CoalesceGap:  float64Ptr(3.0),
 				Report:       boolPtr(true),
 			},
+			Audita: AuditaConfig{
+				Binary:                   "audita",
+				Timeout:                  "3h",
+				LLMAPIKeyEnv:             "AUDITA_LLM_API_KEY",
+				Modules:                  []string{"glossary", "homophones"},
+				BaseURL:                  "https://openrouter.ai/api/v1",
+				Model:                    "openrouter/google/gemma-4-31b-it",
+				LLMConcurrency:           intPtr(1),
+				ValidationModel:          "",
+				ValidationLLMConcurrency: intPtr(1),
+				Report:                   boolPtr(true),
+			},
 		},
 		Session: &SessionConfig{
 			SessionID: "2026-05-03",
@@ -485,6 +737,12 @@ func TestExamplesLoadAndValidate(t *testing.T) {

 func writeConfigFiles(t *testing.T, pipelineYAML, sessionYAML string) (string, string) {
 	t.Helper()
+	if !strings.Contains(pipelineYAML, "\naudita:") && !strings.HasPrefix(pipelineYAML, "audita:") {
+		if !strings.HasSuffix(pipelineYAML, "\n") {
+			pipelineYAML += "\n"
+		}
+		pipelineYAML += "audita:\n  binary: audita\n"
+	}

 	dir := t.TempDir()
 	pipelinePath := filepath.Join(dir, "pipeline.yml")
--- a/internal/config/validate.go
+++ b/internal/config/validate.go
@@ -39,7 +39,7 @@ func validatePipeline(cfg *PipelineConfig) error {
 	if err := validateSeriatim(cfg.Seriatim); err != nil {
 		return err
 	}
-	if err := validateDuration("pipeline.audita.timeout", cfg.Audita.Timeout); err != nil {
+	if err := validateAudita(cfg.Audita); err != nil {
 		return err
 	}
 	if err := validateDuration("pipeline.analyzer.timeout", cfg.Analyzer.Timeout); err != nil {
@@ -122,6 +122,57 @@ func validateSeriatim(cfg SeriatimConfig) error {
 	return nil
 }

+func validateAudita(cfg AuditaConfig) error {
+	if strings.TrimSpace(cfg.Binary) == "" {
+		return fmt.Errorf("pipeline.audita.binary is required")
+	}
+	if err := validateDuration("pipeline.audita.timeout", cfg.Timeout); err != nil {
+		return err
+	}
+	if strings.TrimSpace(cfg.LLMAPIKeyEnv) == "" {
+		return fmt.Errorf("pipeline.audita.llm_api_key_env is required")
+	}
+	if len(cfg.Modules) == 0 {
+		return fmt.Errorf("pipeline.audita.modules must include at least one module")
+	}
+	for i, mod := range cfg.Modules {
+		m := strings.TrimSpace(mod)
+		if m == "" {
+			return fmt.Errorf("pipeline.audita.modules[%d] must be non-empty", i)
+		}
+		switch m {
+		case "glossary", "homophones", "spoken_word", "grammar":
+		default:
+			return fmt.Errorf("pipeline.audita.modules[%d] must be one of: glossary, homophones, spoken_word, grammar", i)
+		}
+	}
+	if strings.TrimSpace(cfg.BaseURL) != "" {
+		u, err := url.Parse(cfg.BaseURL)
+		if err != nil || u.Scheme == "" || u.Host == "" {
+			if err != nil {
+				return fmt.Errorf("pipeline.audita.base_url must be a valid URL: %w", err)
+			}
+			return fmt.Errorf("pipeline.audita.base_url must be a valid URL")
+		}
+	}
+	if strings.TrimSpace(cfg.Model) == "" {
+		return fmt.Errorf("pipeline.audita.model is required")
+	}
+	if cfg.LLMConcurrency == nil {
+		return fmt.Errorf("pipeline.audita.llm_concurrency must be set (defaults should populate this)")
+	}
+	if *cfg.LLMConcurrency <= 0 {
+		return fmt.Errorf("pipeline.audita.llm_concurrency must be > 0")
+	}
+	if cfg.ValidationLLMConcurrency == nil {
+		return fmt.Errorf("pipeline.audita.validation_llm_concurrency must be set (defaults should populate this)")
+	}
+	if *cfg.ValidationLLMConcurrency <= 0 {
+		return fmt.Errorf("pipeline.audita.validation_llm_concurrency must be > 0")
+	}
+	return nil
+}
+
 func validateSession(cfg *SessionConfig) error {
 	if strings.TrimSpace(cfg.SessionID) == "" {
 		return fmt.Errorf("session.session_id is required")