Implemented multiple campaign support via a campaign directory registry with explicit campaign IDs

internal/app/campaign_config_path.go

@@ -1,49 +1,44 @@
 package app
 
 import (
-	"errors"
 	"fmt"
-	"os"
 	"path/filepath"
 	"strings"
 
 	"gitea.maximumdirect.net/eric/narratio/internal/config"
 )
 
-func resolveCampaignConfigPath(flagValue string) (string, error) {
-	return resolveCampaignConfigPathWithCandidates(flagValue, config.DefaultCampaignConfigSearchPaths)
+func resolveCampaignConfigPath(pipelineCfg *config.PipelineConfig, campaignIDFlag, campaignFileFlag string) (string, error) {
+	campaignID := strings.TrimSpace(campaignIDFlag)
+	campaignFile := strings.TrimSpace(campaignFileFlag)
+	if campaignID != "" && campaignFile != "" {
+		return "", fmt.Errorf("--campaign and --campaign-file are mutually exclusive")
+	}
+	if campaignFile != "" {
+		return filepath.Clean(campaignFile), nil
+	}
+	if campaignID == "" && pipelineCfg != nil {
+		campaignID = strings.TrimSpace(pipelineCfg.Campaigns.DefaultCampaignID)
+	}
+	if campaignID == "" {
+		return "", fmt.Errorf("no campaign selected; pass --campaign <id> or set pipeline.campaigns.default_campaign_id")
+	}
+	if err := validateCampaignIDToken(campaignID); err != nil {
+		return "", err
+	}
+	if pipelineCfg == nil || strings.TrimSpace(pipelineCfg.Campaigns.Root) == "" {
+		return "", fmt.Errorf("pipeline.campaigns.root is required to select campaign %q", campaignID)
+	}
+	return filepath.Clean(filepath.Join(pipelineCfg.Campaigns.Root, campaignID, "campaign.yml")), nil
 }
 
-func resolveCampaignConfigPathWithCandidates(flagValue string, candidates []string) (string, error) {
-	if explicit := strings.TrimSpace(flagValue); explicit != "" {
-		return explicit, nil
+func validateCampaignIDToken(campaignID string) error {
+	if filepath.IsAbs(campaignID) ||
+		strings.Contains(campaignID, "/") ||
+		strings.Contains(campaignID, `\`) ||
+		campaignID == "." ||
+		campaignID == ".." {
+		return fmt.Errorf("campaign id %q must be a single path segment", campaignID)
 	}
-
-	ordered := make([]string, 0, len(candidates))
-	for _, raw := range candidates {
-		path := strings.TrimSpace(raw)
-		if path == "" {
-			continue
-		}
-		ordered = append(ordered, path)
-		info, err := os.Stat(path)
-		if err == nil {
-			if info.IsDir() {
-				continue
-			}
-			return filepath.Clean(path), nil
-		}
-		if errors.Is(err, os.ErrNotExist) {
-			continue
-		}
-		return "", fmt.Errorf("check default campaign config %q: %w", path, err)
-	}
-
-	if len(ordered) == 0 {
-		return "", fmt.Errorf("no campaign config path provided and no default locations configured")
-	}
-	return "", fmt.Errorf(
-		"no campaign config path provided and no default campaign config found; searched: %s; pass --campaign to use an explicit path",
-		strings.Join(ordered, ", "),
-	)
+	return nil
 }