eric/narratio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 27 Wiki Activity

Honor explicit Notarius working directories

Browse Source
This commit is contained in:
Eric Rakestraw
2026-09-07 11:54:35 +00:00
parent 884a62e8a6
commit 99d1a0b926
4 changed files with 27 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
internal/config/notarius_test.go
View File

@@ -99,6 +99,26 @@ notarius:
if explicit.Notarius.WorkingDirectory != filepath.Join(dir, "runtime") {
t.Fatalf("explicit working_directory = %q, want %q", explicit.Notarius.WorkingDirectory, filepath.Join(dir, "runtime"))
}
for _, value := range []string{`""`, `" "`} {
t.Run("explicit blank "+value, func(t *testing.T) {
blankPath := filepath.Join(t.TempDir(), "pipeline.yml")
blankYAML := strings.Replace(pipelineYAML, " pipeline_id: dnd-session\n", " pipeline_id: dnd-session\n working_directory: "+value+"\n", 1)
if err := os.WriteFile(blankPath, []byte(blankYAML), 0o644); err != nil {
t.Fatal(err)
}
blank, err := LoadPipeline(blankPath)
if err != nil {
t.Fatalf("LoadPipeline(explicit blank working directory) error = %v", err)
}
if blank.Notarius.WorkingDirectory != "" {
t.Fatalf("explicit blank working_directory = %q, want empty", blank.Notarius.WorkingDirectory)
}
if err := ValidatePipelineConfig(blank); err == nil || !strings.Contains(err.Error(), "working_directory is required") {
t.Fatalf("ValidatePipelineConfig() error = %v, want required working directory", err)
}
})
}
}
func TestNotariusRelativePathsDoNotMakeEffectiveDigestLocationDependent(t *testing.T) {