Add artifact provenance and stage skip outcomes

internal/manifest/manifest.go

@@ -3,6 +3,8 @@ package manifest
 import (
 	"strings"
 	"time"
+
+	"gitea.maximumdirect.net/eric/narratio/internal/artifactmodel"
 )
 
 // ErrorRecord captures structured error metadata at run or stage scope.
@@ -28,9 +30,11 @@ type InputRecord struct {
 
 // ArtifactRecord captures one produced artifact and optional remote metadata.
 type ArtifactRecord struct {
-	Kind      string `json:"kind"`
-	SourceID  string `json:"source_id,omitempty"`
-	LocalPath string `json:"local_path"`
+	Kind               string                            `json:"kind"`
+	SourceID           string                            `json:"source_id,omitempty"`
+	LocalPath          string                            `json:"local_path"`
+	Contract           *artifactmodel.ContractMetadata   `json:"contract,omitempty"`
+	ExternalProvenance *artifactmodel.ExternalProvenance `json:"external_provenance,omitempty"`
 	// ProducerRunID identifies the run that produced this durable artifact.
 	ProducerRunID string `json:"producer_run_id,omitempty"`
 	RemoteKey     string `json:"remote_key,omitempty"`
@@ -120,6 +124,7 @@ func (m *Manifest) MarkStageSkipped(name string, at time.Time, reason string) {
 	s.Status = StatusSkipped
 	s.CompletedAt = timePtr(at)
 	s.Error = &ErrorRecord{Message: strings.TrimSpace(reason), Code: "skipped", At: timePtr(at)}
+	s.Outputs = nil
 	s.UpdatedAt = at
 	m.UpdatedAt = at
 }

internal/manifest/manifest_test.go

@@ -110,3 +110,23 @@ func TestMarkStageSucceededClearsError(t *testing.T) {
 		t.Fatalf("error = %#v, want nil on success", stage.Error)
 	}
 }
+
+func TestMarkStageSkippedClearsEarlierOutputs(t *testing.T) {
+	m := New("2026-05-03", time.Date(2026, 5, 3, 10, 0, 0, 0, time.UTC))
+	m.MarkStageSucceeded("extract", time.Date(2026, 5, 3, 10, 1, 0, 0, time.UTC), []ArtifactRecord{
+		{Kind: "structured_data", SourceID: "narratio.example.characters", LocalPath: "artifacts/characters.json"},
+	})
+
+	m.MarkStageSkipped("extract", time.Date(2026, 5, 3, 10, 2, 0, 0, time.UTC), "integration_disabled")
+
+	stage := m.Stages["extract"]
+	if stage == nil {
+		t.Fatal("missing stage record")
+	}
+	if stage.Status != StatusSkipped {
+		t.Fatalf("status = %q, want %q", stage.Status, StatusSkipped)
+	}
+	if len(stage.Outputs) != 0 {
+		t.Fatalf("outputs = %#v, want cleared", stage.Outputs)
+	}
+}

internal/manifest/run_manifest.go

@@ -119,6 +119,7 @@ func (m *RunManifest) MarkStageSkipped(name string, at time.Time, reason string)
 	s.Status = StatusSkipped
 	s.CompletedAt = timePtr(at)
 	s.Error = &ErrorRecord{Message: strings.TrimSpace(reason), Code: "skipped", At: timePtr(at)}
+	s.Outputs = nil
 	s.UpdatedAt = at
 	m.UpdatedAt = at
 }

internal/manifest/store_test.go

@@ -8,6 +8,8 @@ import (
 	"strings"
 	"testing"
 	"time"
+
+	"gitea.maximumdirect.net/eric/narratio/internal/artifactmodel"
 )
 
 func TestLocalStoreCreateSaveLoadRoundTrip(t *testing.T) {
@@ -64,6 +66,76 @@ func TestLocalStoreCreateSaveLoadRoundTrip(t *testing.T) {
 	}
 }
 
+func TestLocalStoreArtifactMetadataCompatibility(t *testing.T) {
+	store := &LocalStore{}
+	ctx := context.Background()
+	dir := t.TempDir()
+	oldPath := filepath.Join(dir, "old-manifest.json")
+	oldJSON := `{
+  "session_id": "2026-05-03",
+  "created_at": "2026-05-03T10:00:00Z",
+  "updated_at": "2026-05-03T10:01:00Z",
+  "stages": {
+    "analyze": {
+      "name": "analyze",
+      "status": "succeeded",
+      "created_at": "2026-05-03T10:00:00Z",
+      "updated_at": "2026-05-03T10:01:00Z",
+      "outputs": [{"kind":"scriptorium_artifact","local_path":"artifacts/recap.md"}]
+    }
+  }
+}`
+	if err := os.WriteFile(oldPath, []byte(oldJSON), 0o644); err != nil {
+		t.Fatalf("WriteFile() old manifest error = %v", err)
+	}
+
+	loaded, err := store.Load(ctx, oldPath)
+	if err != nil {
+		t.Fatalf("Load() old manifest error = %v", err)
+	}
+	oldOutput := loaded.Stages["analyze"].Outputs[0]
+	if oldOutput.Contract != nil || oldOutput.ExternalProvenance != nil {
+		t.Fatalf("old output metadata = %#v, %#v; want nil", oldOutput.Contract, oldOutput.ExternalProvenance)
+	}
+	if err := store.Save(ctx, oldPath, loaded); err != nil {
+		t.Fatalf("Save() old manifest error = %v", err)
+	}
+	roundTripped, err := os.ReadFile(oldPath)
+	if err != nil {
+		t.Fatalf("ReadFile() round-tripped old manifest error = %v", err)
+	}
+	if strings.Contains(string(roundTripped), `"contract"`) || strings.Contains(string(roundTripped), `"external_provenance"`) {
+		t.Fatalf("old manifest gained fabricated metadata:\n%s", roundTripped)
+	}
+
+	loaded.Stages["analyze"].Outputs[0].Contract = &artifactmodel.ContractMetadata{
+		MediaType:     "application/json",
+		SchemaID:      "example.recap",
+		SchemaVersion: "v1",
+	}
+	loaded.Stages["analyze"].Outputs[0].ExternalProvenance = &artifactmodel.ExternalProvenance{
+		System:     "example",
+		RunID:      "external-run",
+		PipelineID: "pipeline",
+		ArtifactID: "recap",
+	}
+	metadataPath := filepath.Join(dir, "metadata-manifest.json")
+	if err := store.Save(ctx, metadataPath, loaded); err != nil {
+		t.Fatalf("Save() metadata manifest error = %v", err)
+	}
+	withMetadata, err := store.Load(ctx, metadataPath)
+	if err != nil {
+		t.Fatalf("Load() metadata manifest error = %v", err)
+	}
+	got := withMetadata.Stages["analyze"].Outputs[0]
+	if got.Contract == nil || got.Contract.SchemaID != "example.recap" {
+		t.Fatalf("contract = %#v, want persisted contract", got.Contract)
+	}
+	if got.ExternalProvenance == nil || got.ExternalProvenance.RunID != "external-run" {
+		t.Fatalf("external provenance = %#v, want persisted provenance", got.ExternalProvenance)
+	}
+}
+
 func TestLocalStoreSaveUpdatesTimestamp(t *testing.T) {
 	store := &LocalStore{}
 	ctx := context.Background()