eric/narratio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 15 Wiki Activity

Audita API key credentials are now optional

Browse Source
This commit is contained in:
Eric Rakestraw
2026-05-04 10:53:53 -05:00
parent 97ff1578c6
commit 89d7bc75c3
7 changed files with 35 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
internal/adapters/audita/subprocess.go
View File

@@ -83,9 +83,6 @@ func NewSubprocessRunner(cfg SubprocessRunnerConfig) (*SubprocessRunner, error)
if cfg.Timeout <= 0 {
return nil, fmt.Errorf("audita timeout must be > 0")
}
if strings.TrimSpace(cfg.LLMAPIKeyEnv) == "" {
return nil, fmt.Errorf("audita llm api key env var name is required")
}
if len(cfg.Modules) == 0 {
return nil, fmt.Errorf("audita modules must include at least one module")
}
@@ -160,13 +157,14 @@ func (r *SubprocessRunner) Run(ctx context.Context, req PolishRequest) (PolishRe
}
args := r.buildArgs(req, reqModules)
credential, credentialPresent := os.LookupEnv(r.llmAPIKeyEnv)
if !credentialPresent || strings.TrimSpace(credential) == "" {
return PolishResult{}, fmt.Errorf("audita credential env var %q is required but not set", r.llmAPIKeyEnv)
}
env := map[string]string{
"AUDITA_LLM_API_KEY": credential,
credentialPresent := false
env := map[string]string{}
if strings.TrimSpace(r.llmAPIKeyEnv) != "" {
credential, ok := os.LookupEnv(r.llmAPIKeyEnv)
if ok && strings.TrimSpace(credential) != "" {
env["AUDITA_LLM_API_KEY"] = credential
credentialPresent = true
}
}
primaryConcurrencyViaEnv := false
if r.llmConcurrency != nil {

39
internal/adapters/audita/subprocess_test.go
View File

@@ -120,33 +120,38 @@ func TestSubprocessRunnerSuccessArgsEnvAndValidation(t *testing.T) {
}
}
func TestSubprocessRunnerMissingCredentialFails(t *testing.T) {
func TestSubprocessRunnerMissingCredentialEnvOmitsCredential(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("helper wrapper script uses /bin/sh")
}
t.Setenv("GO_WANT_AUDITA_HELPER", "1")
t.Setenv("AUDITA_HELPER_MODE", "success")
recordPath := filepath.Join(t.TempDir(), "record.json")
t.Setenv("AUDITA_HELPER_RECORD_PATH", recordPath)
llmConcurrency := 1
runner, err := NewSubprocessRunner(SubprocessRunnerConfig{
Binary: "audita",
Timeout: mustParseAuditaDuration(t, "1s"),
runner := mustAuditaRunner(t, SubprocessRunnerConfig{
Binary: writeAuditaHelperWrapper(t),
Timeout: mustParseAuditaDuration(t, "2s"),
LLMAPIKeyEnv: "MISSING_AUDITA_KEY",
Modules: []string{"glossary"},
BaseURL: "https://openrouter.ai/api/v1",
Model: "openrouter/google/gemma-4-31b-it",
LLMConcurrency: &llmConcurrency,
Report: false,
})
if err != nil {
t.Fatalf("NewSubprocessRunner() error = %v", err)
}
req := auditaReqForTest(t, false)
req := PolishRequest{
MergedTranscriptPath: "/tmp/merged.json",
GlossaryPath: "/tmp/glossary.yml",
OutputProcessedPath: "/tmp/processed.json",
WorkDir: "/tmp/audita-work",
res, err := runner.Run(context.Background(), req)
if err != nil {
t.Fatalf("Run() error = %v", err)
}
_, err = runner.Run(context.Background(), req)
if err == nil {
t.Fatal("expected error, got nil")
if res.Metadata["credential_present"] != false {
t.Fatalf("credential_present = %#v, want false", res.Metadata["credential_present"])
}
if !strings.Contains(err.Error(), "MISSING_AUDITA_KEY") {
t.Fatalf("error = %q, want env var name context", err.Error())
rec := readAuditaHelperRecord(t, recordPath)
if rec.Env["AUDITA_LLM_API_KEY"] != "" {
t.Fatalf("AUDITA_LLM_API_KEY = %q, want omitted/empty", rec.Env["AUDITA_LLM_API_KEY"])
}
}