Add strict pipeline and session config loading

internal/config/load_validate_test.go

@@ -0,0 +1,182 @@
+package config
+
+import (
+	"os"
+	"path/filepath"
+	"strings"
+	"testing"
+)
+
+func TestLoadAndValidate(t *testing.T) {
+	tests := []struct {
+		name         string
+		pipelineYAML string
+		sessionYAML  string
+		wantLoadErr  string
+		wantValidate string
+	}{
+		{
+			name: "valid minimal config",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  timeout: 10m
+seriatim:
+  timeout: 30s
+audita:
+  timeout: 1h
+analyzer:
+  timeout: 20m
+notification:
+  timeout: 15s
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+		},
+		{
+			name: "unknown pipeline field fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+bogus: true
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantLoadErr: "field bogus not found",
+		},
+		{
+			name: "unknown session field fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+unknown_field: true
+`,
+			wantLoadErr: "field unknown_field not found",
+		},
+		{
+			name: "missing required field fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+`,
+			sessionYAML: `session_id: ""
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantValidate: "session.session_id is required",
+		},
+		{
+			name: "invalid timeout fails",
+			pipelineYAML: `workspace:
+  root: /tmp/narratio
+whisperx:
+  timeout: definitely-not-a-duration
+`,
+			sessionYAML: `session_id: 2026-05-03
+inputs:
+  audio_dir: ./audio
+  speakers_file: ./speakers.yml
+  autocorrect_file: ./autocorrect.yml
+  glossary_file: ./glossary.yml
+`,
+			wantValidate: "pipeline.whisperx.timeout must be a valid duration",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			pipelinePath, sessionPath := writeConfigFiles(t, tt.pipelineYAML, tt.sessionYAML)
+
+			cfg, err := Load(pipelinePath, sessionPath)
+			if tt.wantLoadErr != "" {
+				if err == nil {
+					t.Fatalf("expected load error containing %q, got nil", tt.wantLoadErr)
+				}
+				if !strings.Contains(err.Error(), tt.wantLoadErr) {
+					t.Fatalf("load error = %q, want to contain %q", err.Error(), tt.wantLoadErr)
+				}
+				return
+			}
+
+			if err != nil {
+				t.Fatalf("Load() error = %v", err)
+			}
+			if cfg.PipelinePath != pipelinePath {
+				t.Fatalf("PipelinePath = %q, want %q", cfg.PipelinePath, pipelinePath)
+			}
+			if cfg.SessionPath != sessionPath {
+				t.Fatalf("SessionPath = %q, want %q", cfg.SessionPath, sessionPath)
+			}
+
+			err = Validate(cfg)
+			if tt.wantValidate != "" {
+				if err == nil {
+					t.Fatalf("expected validation error containing %q, got nil", tt.wantValidate)
+				}
+				if !strings.Contains(err.Error(), tt.wantValidate) {
+					t.Fatalf("validation error = %q, want to contain %q", err.Error(), tt.wantValidate)
+				}
+				return
+			}
+			if err != nil {
+				t.Fatalf("Validate() error = %v", err)
+			}
+		})
+	}
+}
+
+func TestValidateMissingAudioSource(t *testing.T) {
+	cfg := &Config{
+		Pipeline: &PipelineConfig{Workspace: WorkspaceConfig{Root: "/tmp/narratio"}},
+		Session: &SessionConfig{
+			SessionID: "2026-05-03",
+			Inputs: SessionInputsConfig{
+				SpeakersFile:    "speakers.yml",
+				AutocorrectFile: "autocorrect.yml",
+				GlossaryFile:    "glossary.yml",
+			},
+		},
+	}
+
+	err := Validate(cfg)
+	if err == nil {
+		t.Fatal("expected validation error, got nil")
+	}
+	if !strings.Contains(err.Error(), "audio_dir or at least one audio_files") {
+		t.Fatalf("error = %q, want audio source guidance", err.Error())
+	}
+}
+
+func writeConfigFiles(t *testing.T, pipelineYAML, sessionYAML string) (string, string) {
+	t.Helper()
+
+	dir := t.TempDir()
+	pipelinePath := filepath.Join(dir, "pipeline.yml")
+	sessionPath := filepath.Join(dir, "session.yml")
+
+	if err := os.WriteFile(pipelinePath, []byte(pipelineYAML), 0o644); err != nil {
+		t.Fatalf("write pipeline.yml: %v", err)
+	}
+	if err := os.WriteFile(sessionPath, []byte(sessionYAML), 0o644); err != nil {
+		t.Fatalf("write session.yml: %v", err)
+	}
+
+	return pipelinePath, sessionPath
+}