eric/narratio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 27 Wiki Activity

Validate published output declarations

Browse Source
This commit is contained in:
Eric Rakestraw
2026-09-05 14:14:33 +00:00
parent 470450e509
commit 4048996652
14 changed files with 107 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
internal/artifacts/remote_commit_test.go
View File

@@ -77,6 +77,24 @@ func TestParseImmutableRunObjectKeyRejectsUnsafeOrMutableKeys(t *testing.T) {
}
}
func TestParsePublishedOutputObjectKeyRequiresPublishedNamespace(t *testing.T) {
prefix := testCurrentSessionPrefix()
runID := "20260519T010203Z-a1b2c3d4"
key := S3RunRelativeDestinationKey(S3RunPrefix(prefix, runID), "published/artifacts/recap.md")
identity, err := ParsePublishedOutputObjectKey(prefix, key)
if err != nil {
t.Fatalf("ParsePublishedOutputObjectKey() error = %v", err)
}
if identity.RunID != runID || identity.Destination != "artifacts/recap.md" {
t.Fatalf("ParsePublishedOutputObjectKey() = %#v", identity)
}
outside := S3RunRelativeDestinationKey(S3RunPrefix(prefix, runID), "artifacts/recap.md")
if _, err := ParsePublishedOutputObjectKey(prefix, outside); err == nil {
t.Fatal("ParsePublishedOutputObjectKey() outside published namespace error = nil")
}
}
func TestRemoteCommitAllowsPublishedOutputFromEarlierSameSessionRunOnly(t *testing.T) {
commit := testRemoteCommit(t, "20260519T010203Z-a1b2c3d4")
prefix := testCurrentSessionPrefix()
@@ -99,6 +117,18 @@ func TestRemoteCommitAllowsPublishedOutputFromEarlierSameSessionRunOnly(t *testi
if err := commit.ValidateForSessionPrefix(prefix); err == nil {
t.Fatal("ValidateForSessionPrefix() earlier non-published object error = nil")
}
commit.Artifacts[1] = published
commit.Artifacts[1].DestinationKey = S3RunRelativeDestinationKey(S3RunPrefix(prefix, commit.RunID), "artifacts/recap.md")
if err := commit.ValidateForSessionPrefix(prefix); err == nil {
t.Fatal("ValidateForSessionPrefix() published output outside published namespace error = nil")
}
commit.Artifacts[1] = published
commit.Artifacts[1].Source = "run:artifacts/recap.md"
if err := commit.ValidateForSessionPrefix(prefix); err == nil {
t.Fatal("ValidateForSessionPrefix() invalid published source error = nil")
}
}
func TestRemoteCommitRejectsEffectivePublishedDestinationCollisionAcrossRuns(t *testing.T) {