Improve structural test diagnostics

internal/app/analyze_checkpoint_recovery_test.go

@@ -5,10 +5,12 @@ import (
 	"errors"
 	"os"
 	"path/filepath"
-	"reflect"
+	"slices"
 	"testing"
 	"time"
 
+	"github.com/google/go-cmp/cmp"
+
 	"gitea.maximumdirect.net/eric/narratio/internal/adapters/scriptorium"
 	"gitea.maximumdirect.net/eric/narratio/internal/config"
 	"gitea.maximumdirect.net/eric/narratio/internal/manifest"
@@ -53,7 +55,7 @@ func TestExecuteStagesRetriesFromLastAnalyzeCheckpoint(t *testing.T) {
 	}); !errors.Is(err, failure) {
 		t.Fatalf("executeStages() error = %v, want quest-log failure", err)
 	}
-	if want := []string{"chronicle-revised", "encounters-revised", "quest-log-revised"}; !reflect.DeepEqual(failingRunner.Calls, want) {
+	if want := []string{"chronicle-revised", "encounters-revised", "quest-log-revised"}; !slices.Equal(failingRunner.Calls, want) {
 		t.Fatalf("failed-run calls = %#v, want %#v", failingRunner.Calls, want)
 	}
 
@@ -66,8 +68,9 @@ func TestExecuteStagesRetriesFromLastAnalyzeCheckpoint(t *testing.T) {
 	assertAnalyzeArtifactStatus(t, failedAnalyze, "encounters", manifest.AnalyzeArtifactCurrent)
 	assertAnalyzeArtifactStatus(t, failedAnalyze, "quest_log", manifest.AnalyzeArtifactFailed)
 	assertAnalyzeArtifactStatus(t, failedAnalyze, "player_handout", manifest.AnalyzeArtifactStale)
-	if got := failedAnalyze.AnalyzeArtifacts["unrelated"]; !reflect.DeepEqual(got, unrelated) {
-		t.Fatalf("unrelated artifact = %#v, want preserved %#v", got, unrelated)
+	gotUnrelated := failedAnalyze.AnalyzeArtifacts["unrelated"]
+	if diff := cmp.Diff(unrelated, gotUnrelated); diff != "" {
+		t.Fatalf("unrelated artifact changed (-want +got):\n%s", diff)
 	}
 	for _, name := range []string{"publish", "notify"} {
 		if got := failed.Stages[name]; got == nil || got.Status != manifest.StatusStale {
@@ -82,7 +85,7 @@ func TestExecuteStagesRetriesFromLastAnalyzeCheckpoint(t *testing.T) {
 	}); err != nil {
 		t.Fatalf("retry executeStages() error = %v", err)
 	}
-	if want := []string{"quest-log-revised", "player-handout-revised"}; !reflect.DeepEqual(retryRunner.Calls, want) {
+	if want := []string{"quest-log-revised", "player-handout-revised"}; !slices.Equal(retryRunner.Calls, want) {
 		t.Fatalf("retry calls = %#v, want %#v", retryRunner.Calls, want)
 	}
 
@@ -148,7 +151,7 @@ func TestExecuteStagesPersistsAnalyzeCheckpointFailureRecovery(t *testing.T) {
 	if !errors.Is(err, checkpointErr) {
 		t.Fatalf("executeStages() error = %v, want checkpoint failure", err)
 	}
-	if want := []string{"chronicle", "encounters"}; !reflect.DeepEqual(runner.Calls, want) {
+	if want := []string{"chronicle", "encounters"}; !slices.Equal(runner.Calls, want) {
 		t.Fatalf("adapter calls = %#v, want %#v", runner.Calls, want)
 	}
 
@@ -322,8 +325,12 @@ func cloneStageRecords(m *manifest.Manifest, names ...string) map[string]manifes
 func assertStageRecordsUnchanged(t *testing.T, m *manifest.Manifest, want map[string]manifest.StageRecord) {
 	t.Helper()
 	for name, expected := range want {
-		if got := m.Stages[name]; got == nil || !reflect.DeepEqual(*got, expected) {
-			t.Fatalf("upstream stage %q = %#v, want unchanged %#v", name, got, expected)
+		got := m.Stages[name]
+		if got == nil {
+			t.Fatalf("upstream stage %q is missing", name)
+		}
+		if diff := cmp.Diff(expected, *got); diff != "" {
+			t.Fatalf("upstream stage %q changed (-want +got):\n%s", name, diff)
 		}
 	}
 }

internal/app/restore_plan_test.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"os"
 	"path/filepath"
-	"reflect"
+	"slices"
 	"strings"
 	"testing"
 
@@ -32,7 +32,7 @@ func TestRestorePlanDefaultScope(t *testing.T) {
 
 	got := actionRelPaths(plan.Actions)
 	want := []string{"artifacts/session_recap.md", "manifest.json", "transcripts/full.json"}
-	if !reflect.DeepEqual(got, want) {
+	if !slices.Equal(got, want) {
 		t.Fatalf("action local paths = %#v, want %#v", got, want)
 	}
 	if plan.DownloadCount != 3 || plan.SkipSameCount != 0 || plan.ConflictCount != 0 {
@@ -54,7 +54,7 @@ func TestRestorePlanIncludeAudio(t *testing.T) {
 	}
 	got := actionRelPaths(plan.Actions)
 	want := []string{"audio/alice.flac", "manifest.json"}
-	if !reflect.DeepEqual(got, want) {
+	if !slices.Equal(got, want) {
 		t.Fatalf("action local paths = %#v, want %#v", got, want)
 	}
 }
@@ -112,7 +112,7 @@ func TestRestorePlanIncludesPreviousCacheByDefault(t *testing.T) {
 
 	got := actionRelPaths(plan.Actions)
 	want := []string{"manifest.json", "previous/artifacts/session_recap.md", "previous/manifest.json"}
-	if !reflect.DeepEqual(got, want) {
+	if !slices.Equal(got, want) {
 		t.Fatalf("action local paths = %#v, want %#v", got, want)
 	}
 }
@@ -133,7 +133,7 @@ func TestRestorePlanIgnoresCurrentSessionArchivedPreviousCache(t *testing.T) {
 
 	got := actionRelPaths(plan.Actions)
 	want := []string{"manifest.json"}
-	if !reflect.DeepEqual(got, want) {
+	if !slices.Equal(got, want) {
 		t.Fatalf("action local paths = %#v, want %#v", got, want)
 	}
 }
@@ -154,7 +154,7 @@ func TestRestorePlanMissingOptionalPreviousCacheSkipsArtifact(t *testing.T) {
 
 	got := actionRelPaths(plan.Actions)
 	want := []string{"manifest.json", "previous/manifest.json"}
-	if !reflect.DeepEqual(got, want) {
+	if !slices.Equal(got, want) {
 		t.Fatalf("action local paths = %#v, want %#v", got, want)
 	}
 }