eric/narratio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 15 Wiki Activity

Confine local file installation paths

Browse Source
This commit is contained in:
Eric Rakestraw
2026-08-10 17:59:29 +00:00
parent 59f3fe3d1d
commit 18ddf00d3d
20 changed files with 694 additions and 153 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
internal/fileops/directory_test.go
View File

@@ -431,6 +431,29 @@ func TestPromoteDirectoryRejectsDestinationInsideSource(t *testing.T) {
}
}
func TestPromoteDirectoryRejectsSymlinkedDestinationAncestor(t *testing.T) {
root := t.TempDir()
source := filepath.Join(root, "source")
if err := os.Mkdir(source, 0o755); err != nil {
t.Fatalf("Mkdir(source) error = %v", err)
}
if err := os.WriteFile(filepath.Join(source, "value.txt"), []byte("source"), 0o644); err != nil {
t.Fatalf("WriteFile(source) error = %v", err)
}
outside := t.TempDir()
if err := os.Symlink(outside, filepath.Join(root, "redirect")); err != nil {
t.Skipf("Symlink unavailable: %v", err)
}
err := PromoteDirectory(source, filepath.Join(root, "redirect", "bundle"))
if err == nil {
t.Fatal("PromoteDirectory() error = nil, want symlink ancestor rejection")
}
if _, err := os.Stat(filepath.Join(outside, "bundle")); !os.IsNotExist(err) {
t.Fatalf("outside bundle exists: stat err = %v", err)
}
}
func mustWriteFile(t *testing.T, path string, data []byte, mode os.FileMode) {
t.Helper()
if err := os.MkdirAll(filepath.Dir(path), 0o755); err != nil {