eric/narratio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 15 Wiki Activity

Removed legacy transcript artifact aliases

Browse Source
This commit is contained in:
Eric Rakestraw
2026-05-19 09:00:41 -05:00
parent 571a289296
commit 08b0f4edc5
8 changed files with 19 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
internal/artifacts/artifact_resolver.go
View File

@@ -84,12 +84,6 @@ var artifactRegistry = map[string]artifactSpec{
},
}
var artifactAliases = map[string]string{
"processed_transcript": ArtifactTranscriptPolished,
"normalized_transcript": ArtifactTranscriptFull,
"trimmed_transcript": ArtifactTranscriptTrimmed,
}
// ResolvedSessionArtifact describes one session-level artifact lookup result.
type ResolvedSessionArtifact struct {
ID string
@@ -113,15 +107,12 @@ func (e *SessionArtifactNotFoundError) Unwrap() error {
return ErrSessionArtifactNotFound
}
// NormalizeSessionArtifactSource maps legacy aliases to canonical IDs and validates IDs.
// NormalizeSessionArtifactSource validates canonical artifact IDs.
func NormalizeSessionArtifactSource(source string) (string, error) {
normalized := strings.TrimSpace(source)
if normalized == "" {
return "", fmt.Errorf("artifact source is required")
}
if alias, ok := artifactAliases[normalized]; ok {
normalized = alias
}
if _, ok := artifactRegistry[normalized]; !ok {
return "", fmt.Errorf("unsupported artifact source %q", source)
}

8
internal/artifacts/artifact_resolver_test.go
View File

@@ -18,9 +18,9 @@ func TestNormalizeSessionArtifactSource(t *testing.T) {
wantID string
wantErr string
}{
{name: "legacy alias processed", source: "processed_transcript", wantID: ArtifactTranscriptPolished},
{name: "legacy alias normalized", source: "normalized_transcript", wantID: ArtifactTranscriptFull},
{name: "legacy alias trimmed", source: "trimmed_transcript", wantID: ArtifactTranscriptTrimmed},
{name: "legacy alias processed unsupported", source: "processed_transcript", wantErr: "unsupported artifact source"},
{name: "legacy alias normalized unsupported", source: "normalized_transcript", wantErr: "unsupported artifact source"},
{name: "legacy alias trimmed unsupported", source: "trimmed_transcript", wantErr: "unsupported artifact source"},
{name: "canonical", source: ArtifactTranscriptTrimmed, wantID: ArtifactTranscriptTrimmed},
{name: "unsupported", source: "narratio.unknown", wantErr: "unsupported artifact source"},
}
@@ -67,7 +67,7 @@ func TestResolveSessionArtifactPrefersManifestOutput(t *testing.T) {
{Kind: "transcript_normalized", LocalPath: manifestPath, ProducerRunID: "run-123"},
})
resolved, err := ResolveSessionArtifact(paths, m, "normalized_transcript")
resolved, err := ResolveSessionArtifact(paths, m, ArtifactTranscriptFull)
if err != nil {
t.Fatalf("ResolveSessionArtifact() error = %v", err)
}