Centralize source manifest validation

internal/state/distributor_test.go

@@ -70,6 +70,60 @@ func TestParseRejectsInvalidEmbeddedManifest(t *testing.T) {
 	assertStateErrorContains(t, err, "source.manifest")
 }
 
+func TestValidateRejectsInvalidEmbeddedManifest(t *testing.T) {
+	tests := map[string]func(bundle.Manifest) bundle.Manifest{
+		"schema version": func(manifest bundle.Manifest) bundle.Manifest {
+			manifest.SchemaVersion = 2
+			return manifest
+		},
+		"empty id": func(manifest bundle.Manifest) bundle.Manifest {
+			manifest.ID = ""
+			return manifest
+		},
+		"bad digest": func(manifest bundle.Manifest) bundle.Manifest {
+			manifest.Digest = "SHA256:099b205780d2b050024868399961b05731729a548d5d6329c7b06a6740dd75fe"
+			return manifest
+		},
+		"zero created": func(manifest bundle.Manifest) bundle.Manifest {
+			manifest.Created = time.Time{}
+			return manifest
+		},
+		"empty files": func(manifest bundle.Manifest) bundle.Manifest {
+			manifest.Files = nil
+			manifest.Digest = bundle.BundleDigest(manifest.Files)
+			return manifest
+		},
+		"unsafe path": func(manifest bundle.Manifest) bundle.Manifest {
+			manifest.Files[0].Path = "../report.md"
+			manifest.Digest = bundle.BundleDigest(manifest.Files)
+			return manifest
+		},
+		"duplicate path": func(manifest bundle.Manifest) bundle.Manifest {
+			manifest.Files[1].Path = manifest.Files[0].Path
+			manifest.Digest = bundle.BundleDigest(manifest.Files)
+			return manifest
+		},
+		"negative size": func(manifest bundle.Manifest) bundle.Manifest {
+			manifest.Files[0].Size = -1
+			manifest.Digest = bundle.BundleDigest(manifest.Files)
+			return manifest
+		},
+		"digest mismatch": func(manifest bundle.Manifest) bundle.Manifest {
+			manifest.Digest = "sha256:0000000000000000000000000000000000000000000000000000000000000000"
+			return manifest
+		},
+	}
+	for name, mutate := range tests {
+		t.Run(name, func(t *testing.T) {
+			source := mutate(validManifest(t))
+			state := *withState(t, validManifest(t), func(*DistributorState) {})
+			state.Source.Manifest = source
+			err := Validate(state)
+			assertStateErrorContains(t, err, "source.manifest")
+		})
+	}
+}
+
 func TestParseRejectsInvalidOutputMetadata(t *testing.T) {
 	source := validManifest(t)
 	tests := map[string]func(*DistributorState){