Remove unused pipeline run coordinator
This commit is contained in:
@@ -290,20 +290,19 @@ Completion criteria:
|
||||
|
||||
Goal:
|
||||
|
||||
Remove the currently unused internal `PipelineRunCoordinator` to avoid
|
||||
maintaining two similar coordination concepts.
|
||||
Remove the currently unused duplicate-run coordinator to avoid maintaining two
|
||||
similar coordination concepts.
|
||||
|
||||
Implementation scope:
|
||||
|
||||
- Delete `PipelineRunCoordinator`, `PipelineRunRecord`,
|
||||
`DuplicatePipelineRunError`, related helpers, and their tests.
|
||||
- Delete the duplicate-run coordinator, its run record and duplicate-run error
|
||||
types, related helpers, and their tests.
|
||||
- Remove or rewrite `docs/internal/app.md` sections that describe the removed
|
||||
coordinator.
|
||||
- Keep `UploadCoordinator`; do not merge upload queueing with the removed
|
||||
duplicate-run coordinator.
|
||||
- Before deletion, confirm with `rg` that production code does not reference
|
||||
`NewPipelineRunCoordinator`, `PipelineRunCoordinator`, or
|
||||
`DuplicatePipelineRunError`.
|
||||
- Before deletion, confirm with search that production code does not reference
|
||||
the duplicate-run coordinator constructor, type, or error.
|
||||
|
||||
Current-behavior documentation updates:
|
||||
|
||||
@@ -313,7 +312,7 @@ Current-behavior documentation updates:
|
||||
Tests:
|
||||
|
||||
- `go test ./internal/app ./internal/cli`
|
||||
- `rg -n "PipelineRunCoordinator|NewPipelineRunCoordinator|DuplicatePipelineRunError" internal docs`
|
||||
- Search `internal` and `docs` for the removed duplicate-run coordinator symbols;
|
||||
should show no stale references after removal.
|
||||
|
||||
Completion criteria:
|
||||
@@ -387,7 +386,7 @@ Recommended consistency checks:
|
||||
rg -n "LoadFile\\(|LoadSecretEnvironment\\(|DefaultConfigPath" internal/app internal/cli
|
||||
rg -n "application/x-tar|application/gzip|application/x-gzip" internal docs
|
||||
rg -n "2006-01-02T15:04:05Z07:00" internal pkg
|
||||
rg -n "PipelineRunCoordinator|NewPipelineRunCoordinator|DuplicatePipelineRunError" internal docs
|
||||
rg -n "duplicate-run coordinator" internal docs
|
||||
```
|
||||
|
||||
The cleanup is complete when:
|
||||
|
||||
Reference in New Issue
Block a user