Centralize publish transform policy validation

2026-05-31 03:25:27 +00:00
parent bda5f6ac6a
commit 93805bcc8c
5 changed files with 275 additions and 27 deletions
--- a/internal/publish/output_test.go
+++ b/internal/publish/output_test.go
@@ -99,3 +99,112 @@ func TestBuildRejectsHTMLWithoutTransform(t *testing.T) {
 		t.Fatal("Build() error = nil, want missing transform error")
 	}
 }
+
+func TestValidateRequestChecksPublishTransformPolicy(t *testing.T) {
+	tests := []struct {
+		name      string
+		publish   config.PublishPolicy
+		transform config.Transform
+		wantErr   bool
+	}{
+		{
+			name:    "source only allowed",
+			publish: config.PublishPolicy{Source: true},
+		},
+		{
+			name:    "html only sidecar allowed",
+			publish: config.PublishPolicy{HTML: true},
+			transform: config.Transform{MarkdownToHTML: &config.MarkdownToHTML{
+				Enabled: true,
+				Mode:    config.TransformModeSidecar,
+			}},
+		},
+		{
+			name:    "source and html sidecar allowed",
+			publish: config.PublishPolicy{Source: true, HTML: true},
+			transform: config.Transform{MarkdownToHTML: &config.MarkdownToHTML{
+				Enabled: true,
+				Mode:    config.TransformModeSidecar,
+			}},
+		},
+		{
+			name:    "no outputs rejected",
+			publish: config.PublishPolicy{},
+			wantErr: true,
+		},
+		{
+			name:    "html without transform rejected",
+			publish: config.PublishPolicy{HTML: true},
+			wantErr: true,
+		},
+		{
+			name:    "html with disabled transform rejected",
+			publish: config.PublishPolicy{HTML: true},
+			transform: config.Transform{MarkdownToHTML: &config.MarkdownToHTML{
+				Enabled: false,
+				Mode:    config.TransformModeSidecar,
+			}},
+			wantErr: true,
+		},
+		{
+			name:    "html with wrong mode rejected",
+			publish: config.PublishPolicy{HTML: true},
+			transform: config.Transform{MarkdownToHTML: &config.MarkdownToHTML{
+				Enabled: true,
+				Mode:    "inline",
+			}},
+			wantErr: true,
+		},
+		{
+			name:    "enabled markdown wrong mode rejected",
+			publish: config.PublishPolicy{Source: true},
+			transform: config.Transform{MarkdownToHTML: &config.MarkdownToHTML{
+				Enabled: true,
+				Mode:    "inline",
+			}},
+			wantErr: true,
+		},
+		{
+			name:    "disabled markdown empty mode allowed",
+			publish: config.PublishPolicy{Source: true},
+			transform: config.Transform{MarkdownToHTML: &config.MarkdownToHTML{
+				Enabled: false,
+			}},
+		},
+		{
+			name:    "disabled markdown sidecar mode allowed",
+			publish: config.PublishPolicy{Source: true},
+			transform: config.Transform{MarkdownToHTML: &config.MarkdownToHTML{
+				Enabled: false,
+				Mode:    config.TransformModeSidecar,
+			}},
+		},
+		{
+			name:    "disabled markdown wrong mode rejected",
+			publish: config.PublishPolicy{Source: true},
+			transform: config.Transform{MarkdownToHTML: &config.MarkdownToHTML{
+				Enabled: false,
+				Mode:    "inline",
+			}},
+			wantErr: true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			err := validateRequest(Request{
+				PipelineID:         "reports",
+				DestinationID:      "archive",
+				SourceBackend:      fake.New(),
+				DestinationBackend: fake.New(),
+				Publish:            tt.publish,
+				Transform:          tt.transform,
+			})
+			if tt.wantErr && err == nil {
+				t.Fatal("validateRequest() error = nil, want error")
+			}
+			if !tt.wantErr && err != nil {
+				t.Fatalf("validateRequest() error = %v", err)
+			}
+		})
+	}
+}