eric/distributor
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

Remove obsolete cleanup helpers

Browse Source
This commit is contained in:
Eric Rakestraw
2026-06-02 18:58:18 +00:00
parent 9684ffd37f
commit 67dc07435d
3 changed files with 9 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/app/run_test.go
View File

@@ -159,9 +159,9 @@ pipelines:
}
}
func TestWriteSSHWarningsReportsInsecureHostKeyPolicy(t *testing.T) {
func TestSSHWarningsReportInsecureHostKeyPolicy(t *testing.T) {
var stdout bytes.Buffer
err := writeSSHWarnings(&stdout, config.Pipeline{
err := writeWarnings(&stdout, sshWarnings(config.Pipeline{
ID: "reports",
Source: config.Backend{
Backend: config.BackendSSH,
@@ -172,9 +172,9 @@ func TestWriteSSHWarningsReportsInsecureHostKeyPolicy(t *testing.T) {
Backend: config.BackendSSH,
SSH: config.SSH{HostKeyPolicy: config.HostKeyPolicyOff},
}},
})
}))
if err != nil {
t.Fatalf("writeSSHWarnings() error = %v", err)
t.Fatalf("writeWarnings() error = %v", err)
}
output := stdout.String()
for _, want := range []string{

8
internal/app/run_warnings.go
View File

@@ -7,10 +7,6 @@ import (
"gitea.maximumdirect.net/eric/distributor/internal/config"
)
func writeSecretConflictWarnings(w io.Writer, conflicts []config.SecretConflict) error {
return writeWarnings(w, secretConflictWarnings(conflicts))
}
func secretConflictWarnings(conflicts []config.SecretConflict) []OutputWarning {
warnings := make([]OutputWarning, 0, len(conflicts))
for _, conflict := range conflicts {
@@ -21,10 +17,6 @@ func secretConflictWarnings(conflicts []config.SecretConflict) []OutputWarning {
return warnings
}
func writeSSHWarnings(w io.Writer, pipeline config.Pipeline) error {
return writeWarnings(w, sshWarnings(pipeline))
}
func sshWarnings(pipeline config.Pipeline) []OutputWarning {
var warnings []OutputWarning
if pipeline.Source.Backend == config.BackendSSH && pipeline.Source.SSH.HostKeyPolicy == config.HostKeyPolicyOff {