Complete Phase 12 grammar module

internal/framework/modules/registry.go

@@ -8,6 +8,7 @@ import (
 	"gitea.maximumdirect.net/eric/audita/internal/core/config"
 	"gitea.maximumdirect.net/eric/audita/internal/core/schema"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/contracts"
+	grammarmodule "gitea.maximumdirect.net/eric/audita/internal/modules/grammar"
 )
 
 const (
@@ -65,10 +66,12 @@ type Factory struct {
 // NewFactory creates a production registry scaffold with known module keys but
 // no real module constructors registered yet.
 func NewFactory(deps Dependencies) *Factory {
-	return &Factory{
+	factory := &Factory{
 		deps:         deps,
 		constructors: make(map[string]Constructor, len(knownModuleKeys)),
 	}
+	_ = factory.RegisterConstructor(ModuleKeyGrammar, constructGrammarModule)
+	return factory
 }
 
 // RegisterConstructor registers a constructor for a known module key.
@@ -87,6 +90,12 @@ func (f *Factory) RegisterConstructor(moduleKey string, constructor Constructor)
 	return nil
 }
 
+func constructGrammarModule(ctx context.Context, req ConstructRequest) (contracts.TranscriptModule, error) {
+	_ = ctx
+	_ = req
+	return grammarmodule.New()
+}
+
 // ModuleForSpec resolves one configured run spec into a module instance.
 func (f *Factory) ModuleForSpec(spec contracts.ModuleRunSpec) (contracts.TranscriptModule, error) {
 	if f == nil {

internal/framework/modules/registry_test.go

@@ -66,7 +66,7 @@ func TestUnsupportedUnknownModuleKeyFailsCleanly(t *testing.T) {
 
 func TestRecognizedButUnimplementedModuleKeyFailsCleanly(t *testing.T) {
 	factory := NewFactory(Dependencies{})
-	for _, key := range []string{ModuleKeyGlossary, ModuleKeyHomophones, ModuleKeySpokenWord, ModuleKeyGrammar} {
+	for _, key := range []string{ModuleKeyGlossary, ModuleKeyHomophones, ModuleKeySpokenWord} {
 		t.Run(key, func(t *testing.T) {
 			_, err := factory.ModuleForSpec(contracts.ModuleRunSpec{ModuleKey: key, InstanceName: key})
 			if err == nil {
@@ -84,6 +84,17 @@ func TestRecognizedButUnimplementedModuleKeyFailsCleanly(t *testing.T) {
 	}
 }
 
+func TestGrammarIsRegisteredAndConstructibleByDefault(t *testing.T) {
+	factory := NewFactory(Dependencies{})
+	module, err := factory.ModuleForSpec(contracts.ModuleRunSpec{ModuleKey: ModuleKeyGrammar, InstanceName: ModuleKeyGrammar})
+	if err != nil {
+		t.Fatalf("ModuleForSpec error: %v", err)
+	}
+	if module.Key() != ModuleKeyGrammar {
+		t.Fatalf("expected grammar module key, got %q", module.Key())
+	}
+}
+
 func TestRegisterConstructorAndConstruct(t *testing.T) {
 	factory := NewFactory(Dependencies{})
 	if err := factory.RegisterConstructor(ModuleKeyGlossary, func(ctx context.Context, req ConstructRequest) (contracts.TranscriptModule, error) {

internal/framework/proposal_generation/generate.go

@@ -54,6 +54,7 @@ type Request struct {
 	Config            *config.Config              `json:"-"`
 	Messages          []contracts.LLMMessage      `json:"messages"`
 	Model             string                      `json:"model,omitempty"`
+	StageName         string                      `json:"stage_name,omitempty"`
 	StartIndex        int                         `json:"start_index"`
 	LLMClient         contracts.StructuredLLMClient
 	Scheduler         contracts.LLMScheduler
@@ -87,7 +88,10 @@ func GenerateCandidates(ctx context.Context, req Request) (Result, error) {
 		return Result{}, fmt.Errorf("messages must not be empty")
 	}
 
-	stage := buildStageName(req.ModuleInstance, req.Section)
+	stage := strings.TrimSpace(req.StageName)
+	if stage == "" {
+		stage = buildStageName(req.ModuleInstance, req.Section)
+	}
 	model := resolveModel(req.Config, req.Model)
 	messages := append([]contracts.LLMMessage(nil), req.Messages...)
 

internal/framework/runner/runner_test.go

@@ -12,6 +12,7 @@ import (
 	"gitea.maximumdirect.net/eric/audita/internal/core/schema"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/contracts"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/llm"
+	"gitea.maximumdirect.net/eric/audita/internal/framework/modules"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/proposal_generation"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/proposals"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/validators"
@@ -651,3 +652,37 @@ func TestRunnerProposalGenerationHelperFlowsThroughPipeline(t *testing.T) {
 		t.Fatalf("expected proposal-generation diagnostics artifacts in %s", filepath.Join(diagDir, "m"))
 	}
 }
+
+func TestRunnerGrammarModuleUsesConfidenceThreshold(t *testing.T) {
+	client := &fakeProposalStructuredClient{
+		responses: []proposal_generation.StructuredCorrectionSet{
+			{
+				Corrections: []proposal_generation.StructuredCorrectionProposal{
+					{TargetSegmentID: 1, OriginalText: "hello ,world", CorrectedText: "Hello, world", Confidence: 0.5},
+				},
+			},
+		},
+	}
+	cfg := config.Default()
+	cfg.Thresholds.Grammar = 0.9
+	factory := modules.NewFactory(modules.Dependencies{})
+	out, err := New(factory).Run(context.Background(), RunInput{
+		Config:            &cfg,
+		Transcript:        &schema.Transcript{Segments: []schema.Segment{{ID: 1, Text: "hello ,world"}}},
+		Glossary:          &schema.Glossary{},
+		ModuleSpecs:       []contracts.ModuleRunSpec{{ModuleKey: "grammar", InstanceName: "grammar"}},
+		ProposalLLMClient: client,
+	})
+	if err != nil {
+		t.Fatalf("Run error: %v", err)
+	}
+	if out.FinalTranscript.Segments[0].Text != "hello ,world" {
+		t.Fatalf("expected no changes due to confidence threshold, got %q", out.FinalTranscript.Segments[0].Text)
+	}
+	if len(out.ModuleResults) != 1 || len(out.ModuleResults[0].ValidatorRejected) == 0 {
+		t.Fatalf("expected validator rejection, got %+v", out.ModuleResults)
+	}
+	if out.ModuleResults[0].ValidatorRejected[0].ReasonCode != validators.ReasonLowConfidence {
+		t.Fatalf("expected low confidence reason, got %+v", out.ModuleResults[0].ValidatorRejected[0])
+	}
+}