Complete Phase 12 grammar module
This commit is contained in:
@@ -59,6 +59,8 @@ Implemented:
|
||||
- Deterministic proposal-index assignment for shared proposal generation.
|
||||
- Proposal-generation prompt/response diagnostics artifact wiring with secret redaction.
|
||||
- Production module-registry scaffolding with known key recognition and explicit unsupported/unimplemented errors.
|
||||
- Production grammar module package with Python-aligned prompt intent and guardrails.
|
||||
- Explicit `--modules grammar` runtime path through runner, shared proposal generation, validators, application, reporting, and diagnostics.
|
||||
- Broad deterministic and CLI/subprocess test coverage for implemented phases through `go test ./...`.
|
||||
- Internal typed structured LLM contract (`StructuredLLMClient.CompleteStructured(ctx, req, out)`).
|
||||
- `internal/framework/llm` instructor-go-backed adapter with:
|
||||
@@ -74,8 +76,8 @@ Implemented:
|
||||
- Generic JSON diagnostics primitives for LLM interactions (request metadata, request payload, response payload, optional error payload) with secret redaction.
|
||||
|
||||
Not yet implemented in runtime pipeline:
|
||||
- Real correction modules.
|
||||
- Domain proposal prompts for real modules.
|
||||
- Real correction modules for `glossary`, `homophones`, and `spoken_word`.
|
||||
- Domain proposal prompts for remaining real modules.
|
||||
- End-to-end transcript polishing behavior.
|
||||
|
||||
## Completed phases
|
||||
@@ -214,7 +216,7 @@ Not implemented in Phase 8 (by design):
|
||||
|
||||
## Remaining work plan
|
||||
|
||||
Next recommended phase: **Phase 12 (grammar module)**.
|
||||
Next recommended phase: **Phase 13 (glossary module and protected-term behavior)**.
|
||||
|
||||
## Phase 9: Structured LLM client and scheduler infrastructure
|
||||
|
||||
@@ -333,52 +335,30 @@ Implemented:
|
||||
- Runner/CLI injection-path tests showing shared proposal generation can flow through runner validation/application semantics using fake modules/clients.
|
||||
|
||||
Not implemented in Phase 11 (by design):
|
||||
- Real production `glossary`, `homophones`, `spoken_word`, and `grammar` modules.
|
||||
- Real production `glossary`, `homophones`, and `spoken_word` modules.
|
||||
- Domain proposal prompts for production modules.
|
||||
- Default CLI end-to-end transcript polishing behavior.
|
||||
|
||||
## Phase 12: Grammar module
|
||||
|
||||
### Purpose
|
||||
Completed.
|
||||
|
||||
Implement the first production module in the Go runtime path. Grammar is a good first real module because it exercises LLM proposal generation and validator chains while remaining constrained to punctuation, capitalization, and spacing cleanup.
|
||||
Implemented:
|
||||
- Production grammar module package in `internal/modules/grammar`.
|
||||
- Grammar prompt builder aligned to Python intent and constrained to punctuation/capitalization/spacing/article cleanup.
|
||||
- Grammar proposal generation through shared `internal/framework/proposal_generation` using `contracts.StructuredLLMClient`.
|
||||
- Scheduler-aware grammar proposal generation through existing scheduler hooks.
|
||||
- Grammar replacement policy `require_unique` (matching Python behavior).
|
||||
- Grammar validator chain using existing deterministic and LLM-backed validator infrastructure.
|
||||
- Grammar confidence threshold enforcement through existing config + confidence-threshold validator behavior.
|
||||
- Explicit runtime support for `--modules grammar` through normalization, chunking, runner, proposal generation, validation, application, and reporting.
|
||||
- Prompt/response diagnostics artifacts for grammar proposal + validator interactions with secret redaction.
|
||||
- Module-level reports for grammar including validator decisions/rejections, applied changes, and skipped changes.
|
||||
- CLI/runtime fake-client tests for approved proposals, validator rejection, application skips, diagnostics, failure/error.log behavior, and report outputs (`--report-json` and run-dir `report.json`).
|
||||
|
||||
### Scope
|
||||
|
||||
Implement:
|
||||
- `grammar` module package.
|
||||
- Grammar prompt builder ported from the Python implementation.
|
||||
- Grammar structured response model.
|
||||
- Grammar replacement policy.
|
||||
- Grammar validator chain.
|
||||
- Grammar confidence threshold handling.
|
||||
- Prompt/response diagnostics.
|
||||
- Module-level report integration.
|
||||
- CLI support for `--modules grammar`.
|
||||
- Fake LLM tests.
|
||||
- Optional real LLM smoke test gated so normal `go test ./...` does not require credentials.
|
||||
|
||||
Do not implement:
|
||||
- Glossary module.
|
||||
- Homophones module.
|
||||
- Spoken-word module.
|
||||
- Default full module sequence as active parity claim.
|
||||
|
||||
### Expected behavior at end of phase
|
||||
|
||||
Running `audita process ... --modules grammar` should perform real grammar-stage transcript polishing using the configured LLM endpoint.
|
||||
|
||||
### Definition of done
|
||||
|
||||
- Grammar module runs in the production runner.
|
||||
- Grammar module generates structured proposals through the LLM client.
|
||||
- Grammar validator chain runs.
|
||||
- Approved grammar proposals are applied.
|
||||
- Applied/skipped grammar changes appear in reports.
|
||||
- Prompt/response diagnostics are written.
|
||||
- `--modules grammar` works end-to-end.
|
||||
- Default pipeline is not yet claimed complete.
|
||||
- `go test ./...` passes without requiring external LLM credentials.
|
||||
Not implemented in Phase 12 (by design):
|
||||
- Production `glossary`, `homophones`, and `spoken_word` modules.
|
||||
- Full default module sequence execution as a feature-complete claim.
|
||||
|
||||
## Phase 13: Glossary module and protected-term behavior
|
||||
|
||||
|
||||
Reference in New Issue
Block a user