Fix the five resilience review findings

internal/framework/validators/llm_validators_test.go

@@ -23,6 +23,7 @@ type fakeStructuredLLMClient struct {
 }
 
 type captureValidationDiagnosticsWriter struct {
+	err                 error
 	lastRequestMetadata any
 }
 
@@ -32,7 +33,7 @@ func (w *captureValidationDiagnosticsWriter) WriteInteraction(stage string, requ
 	_ = responsePayload
 	_ = errorPayload
 	w.lastRequestMetadata = requestMetadata
-	return InteractionArtifacts{}, nil
+	return InteractionArtifacts{}, w.err
 }
 
 func (f *fakeStructuredLLMClient) CompleteStructured(ctx context.Context, req StructuredCompletionRequest, out any) (StructuredCompletionResponse, error) {
@@ -321,3 +322,17 @@ func TestEveryValidationTypeSelectsEmbeddedPromptAndVariables(t *testing.T) {
 		})
 	}
 }
+
+func TestValidationDiagnosticFailureDoesNotChangeDecision(t *testing.T) {
+	cause := errors.New("diagnostic storage unavailable")
+	req := makeReq([]proposals.EnrichedCorrectionProposal{mk(0, "gestures", "Jesters")})
+	req.LLMClient = &fakeStructuredLLMClient{responses: []LLMValidationResponse{{Validations: []LLMValidationDecision{{CorrectionIndex: 0, Approved: true, Confidence: 1, Reason: "ok"}}}}}
+	req.DiagnosticsWriter = &captureValidationDiagnosticsWriter{err: cause}
+	var reported error
+	req.ReportDiagnosticError = func(err error) { reported = err }
+	validator, _ := NewLLMBackedValidator("editorial_review", LLMValidatorTypeEditorialReview)
+	result, err := validator.Validate(context.Background(), req)
+	if err != nil || !errors.Is(reported, cause) || len(result.Decisions) != 1 || !result.Decisions[0].Approved || result.Decisions[0].DiagnosticArtifactPath != "" || len(result.Operations) != 1 || !result.Operations[0].Succeeded || len(result.Operations[0].RecoveryReasons) != 0 {
+		t.Fatalf("debug failure changed outcome: %+v %v reported=%v", result, err, reported)
+	}
+}