Fix deletion conflict accounting coverage

This commit is contained in:
2026-09-25 03:06:57 +00:00
parent 5e2e863fbd
commit d2a6fcfd41
2 changed files with 33 additions and 8 deletions

View File

@@ -4,7 +4,7 @@
**Scope:** The four implementation commits after `31979d4`, compared with
[span-deletion.md](span-deletion.md), [implementation.md](implementation.md),
the agreed user intent, and repository policies.
**Status:** R15 open. Earlier findings R1–R14 are resolved; their evidence and
**Status:** R15 addressed; see the resolution record below. Earlier findings R1–R14 are resolved; their evidence and
resolution records remain in Git history through `24b8992`.
## Architecture Assessment
@@ -71,3 +71,15 @@ test rather than adding overlapping coverage.
behavior, not a guarantee that a model will always propose or approve good edits.
- This review records remediation only; it does not implement the test correction
or any deferred feature.
## Resolution Record
**R15:** Updated the existing conflict test to use `outcomeModule` with a successful
proposal operation. The test requires that operation to be present and checks for
absent failure reasons, recovery reasons, and filtered-proposal records, while
retaining the final-text and skipped-decision assertions. Production code is unchanged.
Validation: `go test ./internal/framework/runner` passed. Repeating the temporary
overlay experiment now fails at the accounting assertion with an erroneous
`proposals_filtered` recovery for the second deletion, confirming that the test
detects the intended regression. The overlay did not modify repository source.