Complete Phase 11 proposal generation framework

internal/framework/runner/runner_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"os"
+	"path/filepath"
 	"strings"
 	"testing"
 
@@ -11,6 +12,7 @@ import (
 	"gitea.maximumdirect.net/eric/audita/internal/core/schema"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/contracts"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/llm"
+	"gitea.maximumdirect.net/eric/audita/internal/framework/proposal_generation"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/proposals"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/validators"
 )
@@ -553,3 +555,99 @@ func TestRunnerAcceptsLLMSchedulerType(t *testing.T) {
 		t.Fatal("expected scheduler instance")
 	}
 }
+
+type proposalGenerationModule struct {
+	key    string
+	policy proposals.ReplacementPolicy
+}
+
+func (m proposalGenerationModule) Key() string                                    { return m.key }
+func (m proposalGenerationModule) ReplacementPolicy() proposals.ReplacementPolicy { return m.policy }
+func (m proposalGenerationModule) Validators() []contracts.Validator              { return nil }
+func (m proposalGenerationModule) Propose(ctx context.Context, req contracts.ProposalRequest) ([]proposals.CorrectionProposal, error) {
+	result, err := proposal_generation.GenerateCandidates(ctx, proposal_generation.Request{
+		ModuleKey:         req.RunSpec.ModuleKey,
+		ModuleInstance:    req.RunSpec.InstanceName,
+		ReplacementPolicy: req.RunSpec.ReplacementPolicy,
+		WorkingTranscript: req.WorkingTranscript,
+		Config:            req.Config,
+		Glossary:          req.Glossary,
+		Messages: []contracts.LLMMessage{
+			{Role: "system", Content: "return transcript corrections"},
+			{Role: "user", Content: "produce one safe correction"},
+		},
+		LLMClient:      req.LLMClient,
+		Scheduler:      req.LLMScheduler,
+		DiagnosticsDir: req.DiagnosticsDir,
+	})
+	if err != nil {
+		return nil, err
+	}
+	return result.Corrections, nil
+}
+
+type fakeProposalStructuredClient struct {
+	responses []proposal_generation.StructuredCorrectionSet
+}
+
+func (f *fakeProposalStructuredClient) CompleteStructured(ctx context.Context, req contracts.StructuredCompletionRequest, out any) (contracts.StructuredCompletionResponse, error) {
+	_ = ctx
+	_ = req
+	if len(f.responses) == 0 {
+		return contracts.StructuredCompletionResponse{}, errors.New("unexpected call")
+	}
+	target, ok := out.(*proposal_generation.StructuredCorrectionSet)
+	if !ok {
+		return contracts.StructuredCompletionResponse{}, errors.New("unexpected output type")
+	}
+	*target = f.responses[0]
+	f.responses = f.responses[1:]
+	return contracts.StructuredCompletionResponse{}, nil
+}
+
+func TestRunnerProposalGenerationHelperFlowsThroughPipeline(t *testing.T) {
+	client := &fakeProposalStructuredClient{
+		responses: []proposal_generation.StructuredCorrectionSet{
+			{
+				Corrections: []proposal_generation.StructuredCorrectionProposal{
+					{TargetSegmentID: 1, OriginalText: "teh", CorrectedText: "the", Confidence: 0.9},
+				},
+			},
+		},
+	}
+	scheduler := &countingScheduler{}
+	cfg := config.Default()
+	diagDir := t.TempDir()
+
+	r := New(fakeFactory{modules: map[string]contracts.TranscriptModule{
+		"m": proposalGenerationModule{key: "m", policy: proposals.ReplacementPolicyRequireUnique},
+	}})
+
+	out, err := r.Run(context.Background(), RunInput{
+		Config:                 &cfg,
+		Transcript:             &schema.Transcript{Segments: []schema.Segment{{ID: 1, Text: "teh cat"}}},
+		ModuleSpecs:            []contracts.ModuleRunSpec{{ModuleKey: "m", InstanceName: "m"}},
+		ProposalLLMClient:      client,
+		ProposalLLMScheduler:   scheduler,
+		ProposalDiagnosticsDir: diagDir,
+	})
+	if err != nil {
+		t.Fatalf("unexpected run error: %v", err)
+	}
+	if out.FinalTranscript.Segments[0].Text != "the cat" {
+		t.Fatalf("expected proposal-generated correction to apply, got %q", out.FinalTranscript.Segments[0].Text)
+	}
+	if scheduler.runs != 1 {
+		t.Fatalf("expected proposal scheduler use, got %d runs", scheduler.runs)
+	}
+	if len(out.ModuleResults) != 1 || len(out.ModuleResults[0].AppliedChanges) != 1 {
+		t.Fatalf("expected one applied change, got %+v", out.ModuleResults)
+	}
+	matches, globErr := filepath.Glob(filepath.Join(diagDir, "m", "*proposal-generation*response-payload.json"))
+	if globErr != nil {
+		t.Fatalf("glob diagnostics: %v", globErr)
+	}
+	if len(matches) == 0 {
+		t.Fatalf("expected proposal-generation diagnostics artifacts in %s", filepath.Join(diagDir, "m"))
+	}
+}