More bugfixes in the glossary protection guard module

tests/test_protection.py

@@ -14,6 +14,17 @@ def _vocabulary():
           - name: "Popov"
             category: npc
             summary: "Popov is an allied NPC."
+          - name: "Jesters"
+            aliases:
+              - "Jester"
+            category: faction
+            summary: "The Jesters are a faction."
+          - name: "Svend"
+            category: pc
+            summary: "Svend is a player character."
+          - name: "Godfrey"
+            category: npc
+            summary: "Godfrey is an NPC."
         """
     )
     return ProtectedVocabulary.from_glossary(glossary)
@@ -59,6 +70,9 @@ def test_protection_allows_correction_toward_protected_term():
     vocabulary = _vocabulary()
 
     assert vocabulary.violation_reason("Pawpaw moves.", "Popov moves.") is None
+    assert vocabulary.violation_reason("gestures", "Jesters") is None
+    assert vocabulary.violation_reason("rank", "Hrank") is None
+    assert vocabulary.violation_reason("spend", "Svend") is None
 
 
 def test_protection_allows_possessive_correction_toward_protected_term():
@@ -67,6 +81,54 @@ def test_protection_allows_possessive_correction_toward_protected_term():
     assert vocabulary.violation_reason("Pawpaw's exhausted.", "Popov's exhausted.") is None
 
 
+def test_protection_blocks_noncanonical_introduced_protected_term():
+    vocabulary = _vocabulary()
+
+    assert (
+        vocabulary.violation_reason("gestures", "jesters")
+        == "correction changes protected glossary term capitalization"
+    )
+    assert (
+        vocabulary.violation_reason("rank", "hrank")
+        == "correction changes protected glossary term capitalization"
+    )
+    assert (
+        vocabulary.violation_reason("spend", "svend")
+        == "correction changes protected glossary term capitalization"
+    )
+
+
+def test_protection_allows_inferred_name_plural():
+    vocabulary = _vocabulary()
+
+    assert vocabulary.violation_reason("Godfrey's", "Godfreys") is None
+
+
+def test_protection_allows_inferred_alias_plural():
+    vocabulary = _vocabulary()
+
+    assert vocabulary.violation_reason("gesture", "Jesters") is None
+
+
+def test_protection_allows_explicit_plural():
+    glossary = parse_glossary_yaml(
+        """
+        glossary:
+          - name: "Mox"
+            plural: "Moxen"
+            category: faction
+            summary: "The Mox are a faction."
+        """
+    )
+    vocabulary = ProtectedVocabulary.from_glossary(glossary)
+
+    assert vocabulary.violation_reason("Mox's", "Moxen") is None
+    assert (
+        vocabulary.violation_reason("Mox's", "moxen")
+        == "correction changes protected glossary term capitalization"
+    )
+
+
 def test_protection_allows_punctuation_around_protected_term():
     vocabulary = _vocabulary()