Refactor validators into package-owned components

internal/framework/runner/runner_test.go

@@ -22,6 +22,7 @@ import (
 	"gitea.maximumdirect.net/eric/audita/internal/framework/proposals"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/responseschema"
 	"gitea.maximumdirect.net/eric/audita/internal/framework/validators"
+	validatormetadata "gitea.maximumdirect.net/eric/audita/internal/validators/metadata"
 )
 
 type fakeFactory struct {
@@ -64,6 +65,58 @@ func (v fakeValidator) Validate(ctx context.Context, req contracts.ValidationReq
 	return v.validateF(req)
 }
 
+type classifiedFakeValidator struct {
+	fakeValidator
+	class validatormetadata.ExecutionClass
+}
+
+func (v classifiedFakeValidator) ExecutionClass() validatormetadata.ExecutionClass {
+	return v.class
+}
+
+func TestReorderValidatorsDeterministicBeforeLLMBacked(t *testing.T) {
+	llm := classifiedFakeValidator{
+		fakeValidator: fakeValidator{name: "llm", validateF: func(req contracts.ValidationRequest) (validators.Result, error) {
+			return validators.Result{ValidatorName: "llm"}, nil
+		}},
+		class: validatormetadata.ExecutionClassLLMBacked,
+	}
+	deterministic := classifiedFakeValidator{
+		fakeValidator: fakeValidator{name: "deterministic", validateF: func(req contracts.ValidationRequest) (validators.Result, error) {
+			return validators.Result{ValidatorName: "deterministic"}, nil
+		}},
+		class: validatormetadata.ExecutionClassDeterministic,
+	}
+
+	ordered, _ := reorderValidatorsForPipeline([]contracts.Validator{llm, deterministic})
+	if len(ordered) != 2 {
+		t.Fatalf("expected 2 validators, got %d", len(ordered))
+	}
+	if ordered[0].Name() != "deterministic" || ordered[1].Name() != "llm" {
+		t.Fatalf("unexpected validator order: %s, %s", ordered[0].Name(), ordered[1].Name())
+	}
+}
+
+func TestReorderValidatorsDefaultsUnclassifiedToDeterministic(t *testing.T) {
+	unclassified := fakeValidator{name: "plain", validateF: func(req contracts.ValidationRequest) (validators.Result, error) {
+		return validators.Result{ValidatorName: "plain"}, nil
+	}}
+	llm := classifiedFakeValidator{
+		fakeValidator: fakeValidator{name: "llm", validateF: func(req contracts.ValidationRequest) (validators.Result, error) {
+			return validators.Result{ValidatorName: "llm"}, nil
+		}},
+		class: validatormetadata.ExecutionClassLLMBacked,
+	}
+
+	ordered, _ := reorderValidatorsForPipeline([]contracts.Validator{llm, unclassified})
+	if len(ordered) != 2 {
+		t.Fatalf("expected 2 validators, got %d", len(ordered))
+	}
+	if ordered[0].Name() != "plain" || ordered[1].Name() != "llm" {
+		t.Fatalf("unexpected validator order with unclassified validator: %s, %s", ordered[0].Name(), ordered[1].Name())
+	}
+}
+
 func TestRunnerOneModuleAppliesProposal(t *testing.T) {
 	transcript := &schema.Transcript{Segments: []schema.Segment{{ID: 1, Speaker: "A", Start: 0, End: 1, Text: "teh cat"}}}
 	r := New(fakeFactory{modules: map[string]contracts.TranscriptModule{