Implemented the spoken_word LLM review module
This commit is contained in:
@@ -6,10 +6,11 @@ from audita.core.errors import AuditaLLMError
|
||||
from audita.core.schemas import parse_glossary_yaml, parse_transcript_json
|
||||
from audita.framework.models import CorrectionProposal, ModuleRunSpec
|
||||
from audita.validators.base import ValidationContext
|
||||
from audita.validators.llm import MeaningReversalValidator, SpokenFormPlausibilityValidator
|
||||
from audita.validators.llm import MeaningReversalValidator, SpokenFormPlausibilityValidator, SpokenWordValidator
|
||||
from audita.validators.prompts import (
|
||||
build_meaning_reversal_messages,
|
||||
build_spoken_form_plausibility_messages,
|
||||
build_spoken_word_messages,
|
||||
)
|
||||
import audita.validators.llm as llm_module
|
||||
|
||||
@@ -204,6 +205,110 @@ def test_meaning_reversal_validator_rejects_reversal_and_approves_nonreversal(tm
|
||||
assert "The figure became invisible in the doorway." in prompt_text
|
||||
|
||||
|
||||
def test_spoken_word_validator_approves_cleanup_and_rejects_rewrite(tmp_path):
|
||||
transcript = parse_transcript_json(
|
||||
"""
|
||||
[
|
||||
{"id": 1, "speaker": "A", "start": 0.0, "end": 1.0, "text": "I, uh, I think we should go."},
|
||||
{"id": 2, "speaker": "A", "start": 1.0, "end": 2.0, "text": "We should maybe proceed carefully."}
|
||||
]
|
||||
"""
|
||||
)
|
||||
proposals = [
|
||||
CorrectionProposal(
|
||||
proposal_index=0,
|
||||
module_instance="spoken_word",
|
||||
module_key="spoken_word",
|
||||
id=1,
|
||||
original_text="I, uh, I think",
|
||||
corrected_text="I think",
|
||||
confidence=0.95,
|
||||
),
|
||||
CorrectionProposal(
|
||||
proposal_index=1,
|
||||
module_instance="spoken_word",
|
||||
module_key="spoken_word",
|
||||
id=2,
|
||||
original_text="maybe proceed carefully",
|
||||
corrected_text="go now",
|
||||
confidence=0.95,
|
||||
),
|
||||
]
|
||||
client = FakeStructuredLLMClient(
|
||||
[
|
||||
{
|
||||
"validations": [
|
||||
{
|
||||
"correction_index": 0,
|
||||
"approved": True,
|
||||
"confidence": 0.97,
|
||||
"reason": "Reasonable dysfluency cleanup that preserves meaning.",
|
||||
},
|
||||
{
|
||||
"correction_index": 1,
|
||||
"approved": False,
|
||||
"confidence": 0.99,
|
||||
"reason": "This changes the substance of the segment rather than cleaning a dysfluency.",
|
||||
},
|
||||
]
|
||||
}
|
||||
]
|
||||
)
|
||||
|
||||
result = SpokenWordValidator("spoken_word_review").validate(
|
||||
_context(proposals=proposals, transcript=transcript, llm_client=client, tmp_path=tmp_path)
|
||||
)
|
||||
|
||||
assert [(decision.proposal_index, decision.approved) for decision in result.decisions] == [
|
||||
(0, True),
|
||||
(1, False),
|
||||
]
|
||||
prompt_text = client.calls[0]["messages"][1]["content"]
|
||||
assert "I think we should go." in prompt_text
|
||||
assert "go now" in prompt_text
|
||||
|
||||
|
||||
def test_spoken_word_validator_allows_punctuation_cleanup_tied_to_dysfluency(tmp_path):
|
||||
transcript = parse_transcript_json(
|
||||
"""
|
||||
[
|
||||
{"id": 1, "speaker": "A", "start": 0.0, "end": 1.0, "text": "Well ... I think we should go."}
|
||||
]
|
||||
"""
|
||||
)
|
||||
proposals = [
|
||||
CorrectionProposal(
|
||||
proposal_index=0,
|
||||
module_instance="spoken_word",
|
||||
module_key="spoken_word",
|
||||
id=1,
|
||||
original_text="Well ... ",
|
||||
corrected_text="",
|
||||
confidence=0.95,
|
||||
)
|
||||
]
|
||||
client = FakeStructuredLLMClient(
|
||||
[
|
||||
{
|
||||
"validations": [
|
||||
{
|
||||
"correction_index": 0,
|
||||
"approved": True,
|
||||
"confidence": 0.95,
|
||||
"reason": "Removes a hesitation artifact without changing substantive meaning.",
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
)
|
||||
|
||||
result = SpokenWordValidator("spoken_word_review").validate(
|
||||
_context(proposals=proposals, transcript=transcript, llm_client=client, tmp_path=tmp_path)
|
||||
)
|
||||
|
||||
assert [(decision.proposal_index, decision.approved) for decision in result.decisions] == [(0, True)]
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
("validator", "payload", "message_fragment"),
|
||||
[
|
||||
@@ -246,6 +351,20 @@ def test_meaning_reversal_validator_rejects_reversal_and_approves_nonreversal(tm
|
||||
},
|
||||
"unknown correction_index",
|
||||
),
|
||||
(
|
||||
SpokenWordValidator("spoken_word_review"),
|
||||
{
|
||||
"validations": [
|
||||
{
|
||||
"correction_index": 99,
|
||||
"approved": True,
|
||||
"confidence": 0.9,
|
||||
"reason": "unknown",
|
||||
}
|
||||
]
|
||||
},
|
||||
"unknown correction_index",
|
||||
),
|
||||
],
|
||||
)
|
||||
def test_llm_validators_reject_bad_correction_indexes(tmp_path, validator, payload, message_fragment):
|
||||
@@ -356,6 +475,27 @@ def test_meaning_reversal_prompt_emphasizes_antonyms_and_segment_context():
|
||||
assert "original_segment_text" in messages[1]["content"]
|
||||
|
||||
|
||||
def test_spoken_word_prompt_emphasizes_dysfluency_cleanup():
|
||||
messages = build_spoken_word_messages(
|
||||
[
|
||||
{
|
||||
"correction_index": 0,
|
||||
"id": 1,
|
||||
"original_segment_text": "I, uh, I think we should go.",
|
||||
"corrected_segment_text": "I think we should go.",
|
||||
"original_text": "I, uh, I think",
|
||||
"corrected_text": "I think",
|
||||
}
|
||||
]
|
||||
)
|
||||
|
||||
combined = messages[0]["content"] + messages[1]["content"]
|
||||
assert "dysfluencies" in combined
|
||||
assert "punctuation" in combined
|
||||
assert "substantive meaning" in combined
|
||||
assert "original_segment_text" in messages[1]["content"]
|
||||
|
||||
|
||||
def test_llm_validators_use_shared_token_batching_helper(monkeypatch, tmp_path):
|
||||
transcript = parse_transcript_json(
|
||||
"""
|
||||
|
||||
@@ -7,7 +7,8 @@ from audita.core.schemas import parse_glossary_yaml, parse_source_transcript_jso
|
||||
from audita.framework.models import ModuleContext, ModuleRunSpec
|
||||
from audita.modules.glossary import GlossaryModule
|
||||
from audita.modules.homophones import HomophonesModule
|
||||
from audita.modules.prompts import build_homophones_proposal_messages
|
||||
from audita.modules.prompts import build_homophones_proposal_messages, build_spoken_word_proposal_messages
|
||||
from audita.modules.spoken_word import SpokenWordModule
|
||||
from audita.pipeline import process_transcript_result
|
||||
|
||||
|
||||
@@ -110,6 +111,70 @@ def test_homophones_prompt_is_explicitly_scoped_to_spoken_form_corrections():
|
||||
assert '"id": 1' in messages[1]["content"]
|
||||
|
||||
|
||||
def test_spoken_word_module_propose_writes_diagnostics_and_returns_proposals_without_api_key(tmp_path):
|
||||
transcript = parse_transcript_json(
|
||||
"""
|
||||
[
|
||||
{"id": 1, "speaker": "Eric", "start": 0.0, "end": 1.0, "text": "I, uh, I think we should go."}
|
||||
]
|
||||
"""
|
||||
)
|
||||
section = chunk_transcript(transcript, max_section_tokens=1000)[0]
|
||||
module = SpokenWordModule()
|
||||
client = FakeStructuredLLMClient(
|
||||
[
|
||||
{
|
||||
"corrections": [
|
||||
{
|
||||
"id": 1,
|
||||
"original_text": "I, uh, I think",
|
||||
"corrected_text": "I think",
|
||||
"confidence": 0.95,
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
)
|
||||
context = ModuleContext(
|
||||
run_spec=ModuleRunSpec(instance_name="spoken_word", module_key="spoken_word", module=module),
|
||||
glossary=_glossary(),
|
||||
config=AuditaConfig.from_sources(env={}),
|
||||
run_dir=tmp_path,
|
||||
llm_client=client,
|
||||
)
|
||||
|
||||
proposals = list(module.propose(section, context))
|
||||
|
||||
assert [(proposal.id, proposal.original_text, proposal.corrected_text, proposal.confidence) for proposal in proposals] == [
|
||||
(1, "I, uh, I think", "I think", 0.95)
|
||||
]
|
||||
assert (tmp_path / "prompt-0000.json").exists()
|
||||
assert (tmp_path / "corrections-0000.json").exists()
|
||||
prompt_text = client.calls[0]["messages"][1]["content"]
|
||||
assert "spoken-word cleanup" in prompt_text
|
||||
assert "exact text span" in prompt_text
|
||||
assert "uh" in prompt_text
|
||||
|
||||
|
||||
def test_spoken_word_prompt_is_explicitly_scoped_to_dysfluency_cleanup():
|
||||
transcript = parse_transcript_json(
|
||||
"""
|
||||
[
|
||||
{"id": 1, "speaker": "Eric", "start": 0.0, "end": 1.0, "text": "Well ... I think we should go."}
|
||||
]
|
||||
"""
|
||||
)
|
||||
section = chunk_transcript(transcript, max_section_tokens=1000)[0]
|
||||
|
||||
messages = build_spoken_word_proposal_messages(section, _glossary())
|
||||
combined = messages[0]["content"] + messages[1]["content"]
|
||||
|
||||
assert "dysfluencies" in combined
|
||||
assert "punctuation" in combined
|
||||
assert "paraphrase" in combined
|
||||
assert '"id": 1' in messages[1]["content"]
|
||||
|
||||
|
||||
def test_process_transcript_result_uses_injected_fake_client_and_applies_sequential_module_updates(tmp_path):
|
||||
transcript = parse_source_transcript_json(
|
||||
"""
|
||||
@@ -200,6 +265,7 @@ def test_process_transcript_result_uses_injected_fake_client_and_applies_sequent
|
||||
]
|
||||
},
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
]
|
||||
)
|
||||
|
||||
@@ -214,6 +280,7 @@ def test_process_transcript_result_uses_injected_fake_client_and_applies_sequent
|
||||
"homophones:spoken_form_plausibility_review",
|
||||
"homophones:meaning_reversal_review",
|
||||
"glossary_2:proposal",
|
||||
"spoken_word:proposal",
|
||||
]
|
||||
assert "There were Jesters at the dam." in client.calls[3]["messages"][1]["content"]
|
||||
|
||||
@@ -256,6 +323,7 @@ def test_process_transcript_result_rejects_below_threshold_proposals_before_llm_
|
||||
},
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
]
|
||||
)
|
||||
|
||||
@@ -266,8 +334,145 @@ def test_process_transcript_result_rejects_below_threshold_proposals_before_llm_
|
||||
"glossary_1:proposal",
|
||||
"homophones:proposal",
|
||||
"glossary_2:proposal",
|
||||
"spoken_word:proposal",
|
||||
]
|
||||
assert result.report.skipped_corrections[0].reason == "proposal confidence below threshold"
|
||||
assert result.report.skipped_corrections[0].source == "validator:proposal_confidence_guard"
|
||||
assert result.report.modules[0].validators[0].rejected_count == 1
|
||||
assert result.report.modules[0].validators[1].candidate_count == 0
|
||||
|
||||
|
||||
def test_process_transcript_result_runs_spoken_word_module_with_full_validator_chain(tmp_path):
|
||||
transcript = parse_source_transcript_json(
|
||||
"""
|
||||
[
|
||||
{"speaker": "Eric", "start": 0.0, "end": 1.0, "text": "I, uh, I think we should go."}
|
||||
]
|
||||
"""
|
||||
)
|
||||
base_config = AuditaConfig.from_sources(env={})
|
||||
config = AuditaConfig(
|
||||
api_key=base_config.api_key,
|
||||
model=base_config.model,
|
||||
base_url=base_config.base_url,
|
||||
max_retries=base_config.max_retries,
|
||||
max_section_tokens=base_config.max_section_tokens,
|
||||
glossary_confidence_threshold=base_config.glossary_confidence_threshold,
|
||||
homophones_confidence_threshold=base_config.homophones_confidence_threshold,
|
||||
spoken_word_confidence_threshold=base_config.spoken_word_confidence_threshold,
|
||||
normalize_max_segment_gap=base_config.normalize_max_segment_gap,
|
||||
normalize_ellipsis_gap=base_config.normalize_ellipsis_gap,
|
||||
normalize_max_segment_duration=base_config.normalize_max_segment_duration,
|
||||
normalize_max_segment_tokens=base_config.normalize_max_segment_tokens,
|
||||
work_dir=tmp_path / "work",
|
||||
work_dir_retention="always",
|
||||
)
|
||||
client = FakeStructuredLLMClient(
|
||||
[
|
||||
{
|
||||
"corrections": [
|
||||
{
|
||||
"id": 1,
|
||||
"original_text": "I, uh, I think",
|
||||
"corrected_text": "I think",
|
||||
"confidence": 0.95,
|
||||
}
|
||||
]
|
||||
},
|
||||
{
|
||||
"validations": [
|
||||
{
|
||||
"correction_index": 0,
|
||||
"approved": True,
|
||||
"confidence": 0.97,
|
||||
"reason": "Reasonable dysfluency cleanup that preserves meaning.",
|
||||
}
|
||||
]
|
||||
},
|
||||
{
|
||||
"validations": [
|
||||
{
|
||||
"correction_index": 0,
|
||||
"approved": True,
|
||||
"confidence": 0.99,
|
||||
"reason": "Does not reverse the segment meaning.",
|
||||
}
|
||||
]
|
||||
},
|
||||
]
|
||||
)
|
||||
|
||||
result = process_transcript_result(
|
||||
transcript,
|
||||
_glossary(),
|
||||
config,
|
||||
module_keys=["spoken_word"],
|
||||
llm_client=client,
|
||||
)
|
||||
|
||||
assert result.transcript[0].text == "I think we should go."
|
||||
assert [call["stage_name"] for call in client.calls] == [
|
||||
"spoken_word:proposal",
|
||||
"spoken_word:spoken_word_review",
|
||||
"spoken_word:meaning_reversal_review",
|
||||
]
|
||||
assert [validator["name"] for validator in result.report.modules[0].to_dict()["validators"]] == [
|
||||
"proposal_confidence_guard",
|
||||
"protected_glossary_guard",
|
||||
"spoken_word_review",
|
||||
"meaning_reversal_review",
|
||||
]
|
||||
|
||||
|
||||
def test_process_transcript_result_rejects_spoken_word_below_threshold_before_llm_validators(tmp_path):
|
||||
transcript = parse_source_transcript_json(
|
||||
"""
|
||||
[
|
||||
{"speaker": "Eric", "start": 0.0, "end": 1.0, "text": "I, uh, I think we should go."}
|
||||
]
|
||||
"""
|
||||
)
|
||||
base_config = AuditaConfig.from_sources(env={})
|
||||
config = AuditaConfig(
|
||||
api_key=base_config.api_key,
|
||||
model=base_config.model,
|
||||
base_url=base_config.base_url,
|
||||
max_retries=base_config.max_retries,
|
||||
max_section_tokens=base_config.max_section_tokens,
|
||||
glossary_confidence_threshold=base_config.glossary_confidence_threshold,
|
||||
homophones_confidence_threshold=base_config.homophones_confidence_threshold,
|
||||
spoken_word_confidence_threshold=0.96,
|
||||
normalize_max_segment_gap=base_config.normalize_max_segment_gap,
|
||||
normalize_ellipsis_gap=base_config.normalize_ellipsis_gap,
|
||||
normalize_max_segment_duration=base_config.normalize_max_segment_duration,
|
||||
normalize_max_segment_tokens=base_config.normalize_max_segment_tokens,
|
||||
work_dir=tmp_path / "work",
|
||||
work_dir_retention="always",
|
||||
)
|
||||
client = FakeStructuredLLMClient(
|
||||
[
|
||||
{
|
||||
"corrections": [
|
||||
{
|
||||
"id": 1,
|
||||
"original_text": "I, uh, I think",
|
||||
"corrected_text": "I think",
|
||||
"confidence": 0.95,
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
)
|
||||
|
||||
result = process_transcript_result(
|
||||
transcript,
|
||||
_glossary(),
|
||||
config,
|
||||
module_keys=["spoken_word"],
|
||||
llm_client=client,
|
||||
)
|
||||
|
||||
assert result.transcript[0].text == "I, uh, I think we should go."
|
||||
assert [call["stage_name"] for call in client.calls] == ["spoken_word:proposal"]
|
||||
assert result.report.skipped_corrections[0].reason == "proposal confidence below threshold"
|
||||
assert result.report.modules[0].validators[1].candidate_count == 0
|
||||
|
||||
@@ -27,6 +27,7 @@ def test_process_help_exposes_framework_flags(capsys):
|
||||
assert "--max-section-tokens" in output
|
||||
assert "--glossary-confidence-threshold" in output
|
||||
assert "--homophones-confidence-threshold" in output
|
||||
assert "--spoken-word-confidence-threshold" in output
|
||||
assert "--work-dir-retention" in output
|
||||
assert "--normalize-max-segment-gap" in output
|
||||
assert "--grammar-validation-enabled" not in output
|
||||
|
||||
@@ -6,6 +6,7 @@ from audita.core.config import (
|
||||
DEFAULT_GLOSSARY_CONFIDENCE_THRESHOLD,
|
||||
DEFAULT_HOMOPHONES_CONFIDENCE_THRESHOLD,
|
||||
DEFAULT_NORMALIZE_MAX_SEGMENT_GAP,
|
||||
DEFAULT_SPOKEN_WORD_CONFIDENCE_THRESHOLD,
|
||||
DEFAULT_WORK_DIR_RETENTION,
|
||||
)
|
||||
from audita.core.errors import AuditaConfigError
|
||||
@@ -19,6 +20,7 @@ def test_default_config_allows_missing_api_key():
|
||||
assert config.module_keys == DEFAULT_MODULE_KEYS
|
||||
assert config.glossary_confidence_threshold == DEFAULT_GLOSSARY_CONFIDENCE_THRESHOLD
|
||||
assert config.homophones_confidence_threshold == DEFAULT_HOMOPHONES_CONFIDENCE_THRESHOLD
|
||||
assert config.spoken_word_confidence_threshold == DEFAULT_SPOKEN_WORD_CONFIDENCE_THRESHOLD
|
||||
assert config.normalize_max_segment_gap == DEFAULT_NORMALIZE_MAX_SEGMENT_GAP
|
||||
assert config.work_dir_retention == DEFAULT_WORK_DIR_RETENTION
|
||||
|
||||
@@ -57,15 +59,18 @@ def test_threshold_overrides_take_precedence():
|
||||
env={
|
||||
"AUDITA_GLOSSARY_CONFIDENCE_THRESHOLD": "0.6",
|
||||
"AUDITA_HOMOPHONES_CONFIDENCE_THRESHOLD": "0.7",
|
||||
"AUDITA_SPOKEN_WORD_CONFIDENCE_THRESHOLD": "0.75",
|
||||
},
|
||||
overrides=ConfigOverrides(
|
||||
glossary_confidence_threshold=0.85,
|
||||
homophones_confidence_threshold=0.9,
|
||||
spoken_word_confidence_threshold=0.95,
|
||||
),
|
||||
)
|
||||
|
||||
assert config.glossary_confidence_threshold == 0.85
|
||||
assert config.homophones_confidence_threshold == 0.9
|
||||
assert config.spoken_word_confidence_threshold == 0.95
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
@@ -86,6 +91,7 @@ def test_invalid_module_sequences_are_rejected(value):
|
||||
[
|
||||
"AUDITA_GLOSSARY_CONFIDENCE_THRESHOLD",
|
||||
"AUDITA_HOMOPHONES_CONFIDENCE_THRESHOLD",
|
||||
"AUDITA_SPOKEN_WORD_CONFIDENCE_THRESHOLD",
|
||||
],
|
||||
)
|
||||
def test_invalid_thresholds_are_rejected(env_name):
|
||||
|
||||
@@ -60,6 +60,7 @@ def test_process_transcript_runs_noop_framework(tmp_path):
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
]
|
||||
)
|
||||
revised = process_transcript(
|
||||
@@ -76,6 +77,7 @@ def test_process_transcript_runs_noop_framework(tmp_path):
|
||||
"glossary_1:proposal",
|
||||
"homophones:proposal",
|
||||
"glossary_2:proposal",
|
||||
"spoken_word:proposal",
|
||||
]
|
||||
|
||||
|
||||
@@ -105,6 +107,7 @@ def test_process_transcript_result_writes_report_and_preserves_skips_per_policy(
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
]
|
||||
)
|
||||
result = process_transcript_result(_transcript(), _glossary(), config, llm_client=llm_client)
|
||||
@@ -126,6 +129,12 @@ def test_process_transcript_result_writes_report_and_preserves_skips_per_policy(
|
||||
"spoken_form_plausibility_review",
|
||||
"meaning_reversal_review",
|
||||
]
|
||||
assert [validator["name"] for validator in result.report.modules[3].to_dict()["validators"]] == [
|
||||
"proposal_confidence_guard",
|
||||
"protected_glossary_guard",
|
||||
"spoken_word_review",
|
||||
"meaning_reversal_review",
|
||||
]
|
||||
|
||||
|
||||
def test_external_report_can_be_written(tmp_path):
|
||||
@@ -135,6 +144,7 @@ def test_external_report_can_be_written(tmp_path):
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
{"corrections": []},
|
||||
]
|
||||
)
|
||||
result = process_transcript_result(_transcript(), _glossary(), config, llm_client=llm_client)
|
||||
@@ -175,7 +185,12 @@ def test_default_module_specs_expose_final_validator_order():
|
||||
"spoken_form_plausibility_review",
|
||||
"meaning_reversal_review",
|
||||
]
|
||||
assert [validator.name for validator in specs[3].module.validators()] == ["protected_glossary_guard"]
|
||||
assert [validator.name for validator in specs[3].module.validators()] == [
|
||||
"proposal_confidence_guard",
|
||||
"protected_glossary_guard",
|
||||
"spoken_word_review",
|
||||
"meaning_reversal_review",
|
||||
]
|
||||
assert [validator.name for validator in specs[4].module.validators()] == ["protected_glossary_guard"]
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user