Preserve page creation outcomes through recovery

cmd/releasekit/main_test.go

@@ -423,16 +423,18 @@ func writeDeliveryReceipt(t *testing.T, repository string, settings cli.BuildSet
 }
 
 type deliveryServerState struct {
-	commit         string
-	product        string
-	remoteCommit   string
-	apiRequests    int
-	pageExists     bool
-	releaseCreates int
-	assetUploads   int
-	assetListReads int
-	noteBody       string
-	assets         map[string][]byte
+	malformedCreate  bool
+	failAssetListing bool
+	commit           string
+	product          string
+	remoteCommit     string
+	apiRequests      int
+	pageExists       bool
+	releaseCreates   int
+	assetUploads     int
+	assetListReads   int
+	noteBody         string
+	assets           map[string][]byte
 }
 
 func newDeliveryServer(t *testing.T, state *deliveryServerState) *httptest.Server {
@@ -483,10 +485,19 @@ func newDeliveryServer(t *testing.T, state *deliveryServerState) *httptest.Serve
 				t.Errorf("release source payload = %#v", payload)
 			}
 			state.pageExists, state.releaseCreates, state.noteBody = true, state.releaseCreates+1, payload.Body
+			if state.malformedCreate {
+				w.WriteHeader(http.StatusCreated)
+				_ = json.NewEncoder(w).Encode(map[string]any{"id": 10, "tag_name": "v1.2.3", "name": "inconsistent response", "body": payload.Body})
+				return
+			}
 			writeDeliveryRelease(w, serverURL, state)
 		case "/api/v1/repos/owner/example/releases/10/assets":
 			if r.Method == http.MethodGet {
 				state.assetListReads++
+				if state.failAssetListing {
+					http.Error(w, "unavailable", 503)
+					return
+				}
 				list := make([]map[string]any, 0, len(state.assets))
 				for name, content := range state.assets {
 					list = append(list, map[string]any{"id": len(list) + 1, "name": name, "size": len(content), "browser_download_url": serverURL + "/files/" + name})
@@ -675,3 +686,21 @@ func TestDeliverRejectsReceiptBuiltFromDirtySourceAfterCleanup(t *testing.T) {
 		t.Fatalf("status=%d requests=%d %s", status, state.apiRequests, stderr.String())
 	}
 }
+
+func TestRecoveredPageCreatePreservesPartialDeliveryOnInspectionFailure(t *testing.T) {
+	repository := newCLIRepository(t)
+	state := &deliveryServerState{malformedCreate: true, failAssetListing: true}
+	server := newDeliveryServer(t, state)
+	defer server.Close()
+	build := cli.BuildSettings{MainPackage: ".", BinaryName: "helper", Targets: []string{"linux/amd64"}}
+	writeDeliveryProfile(t, repository, cli.Settings{Product: "Example Product", Build: &build, Delivery: &cli.DeliverySettings{BaseURL: server.URL, Owner: "owner", Repository: "example"}})
+	state.commit = cliGitOutput(t, repository, "rev-parse", "HEAD")
+	cliGitRun(t, repository, "tag", "v1.2.3")
+	assets, _ := writeDeliveryReceipt(t, repository, build)
+	t.Setenv("RELEASEKIT_GITEA_TOKEN", "fixture-token")
+	var stdout, stderr bytes.Buffer
+	status := run(context.Background(), []string{"deliver", "--repo", repository, "--assets", assets, "v1.2.3"}, &stdout, &stderr)
+	if status != 1 || !strings.Contains(stderr.String(), "state=partial") || state.releaseCreates != 1 || state.assetListReads != 1 || state.assetUploads != 0 {
+		t.Fatalf("status=%d state=%#v %s", status, state, stderr.String())
+	}
+}