Make product checks additive

check.go

@@ -23,28 +23,29 @@ type Candidate struct {
 // local candidate. Remote is retained for publication operations; Check makes
 // no remote availability claim.
 type ReleaseRequest struct {
-	RepositoryDir string
-	Product       string
-	Version       string
-	Remote        string
-	Validate      func(context.Context, Candidate) error
-	Build         *BuildSpec // optional selected-target build after validation.
-	Output        io.Writer
+	RepositoryDir    string
+	Product          string
+	Version          string
+	Remote           string
+	// AdditionalChecks optionally runs product checks after the standard suite.
+	AdditionalChecks func(context.Context, Candidate) error
+	Build            *BuildSpec                             // optional selected-target build after validation.
+	Output           io.Writer
 }
 
 // Check validates one local, committed release candidate. It requires a clean
 // worktree and index on main, a committed note matching Product and Version,
-// and an unused local tag. If Validate is nil, the offline Go test suite runs
-// with the available compatible local Go toolchain and the Go host target.
-// If Build selects targets, Check builds them after validation in temporary
-// storage outside the worktree, then rechecks branch, HEAD, worktree, index,
-// and local tag state. Success establishes local candidate evidence only; it
-// does not establish remote availability.
+// and an unused local tag. It always runs the offline Go test suite with the
+// available compatible local Go toolchain and Go host target, then calls
+// AdditionalChecks when supplied. If Build selects targets, Check builds them
+// after validation in temporary storage outside the worktree, then rechecks
+// branch, HEAD, worktree, index, and local tag state. Success establishes local
+// candidate evidence only; it does not establish remote availability.
 func Check(ctx context.Context, request ReleaseRequest) (Candidate, error) {
 	var validate func(context.Context, candidate.Candidate) error
-	if request.Validate != nil {
+	if request.AdditionalChecks != nil {
 		validate = func(ctx context.Context, captured candidate.Candidate) error {
-			return request.Validate(ctx, Candidate{
+			return request.AdditionalChecks(ctx, Candidate{
 				RepositoryDir: captured.RepositoryDir,
 				Commit:        captured.Commit,
 				Version:       captured.Version,
@@ -52,12 +53,12 @@ func Check(ctx context.Context, request ReleaseRequest) (Candidate, error) {
 		}
 	}
 	checked, err := candidate.Check(ctx, candidate.Request{
-		RepositoryDir: request.RepositoryDir,
-		Product:       request.Product,
-		Version:       request.Version,
-		Validate:      validate,
-		AfterValidate: internalbuild.CandidateCallback(internalBuildSpec(request.Build), request.Output),
-		Output:        request.Output,
+		RepositoryDir:    request.RepositoryDir,
+		Product:          request.Product,
+		Version:          request.Version,
+		AdditionalChecks: validate,
+		AfterValidate:    internalbuild.CandidateCallback(internalBuildSpec(request.Build), request.Output),
+		Output:           request.Output,
 	})
 	if err != nil {
 		return Candidate{}, err