Move shared checks into validation package

publish.go

@@ -4,7 +4,6 @@ import (
 	"context"
 
 	internalbuild "gitea.maximumdirect.net/eric/ReleaseKit/internal/build"
-	"gitea.maximumdirect.net/eric/ReleaseKit/internal/candidate"
 	"gitea.maximumdirect.net/eric/ReleaseKit/internal/publish"
 )
 
@@ -61,22 +60,12 @@ type PublicationResult struct {
 // an unreadable result is unknown. A nil error means publication is confirmed
 // by the successful push or exact remote object match.
 func Publish(ctx context.Context, request ReleaseRequest) (PublicationResult, error) {
-	var validate func(context.Context, candidate.Candidate) error
-	if request.AdditionalChecks != nil {
-		validate = func(ctx context.Context, captured candidate.Candidate) error {
-			return request.AdditionalChecks(ctx, Candidate{
-				RepositoryDir: captured.RepositoryDir,
-				Commit:        captured.Commit,
-				Version:       captured.Version,
-			})
-		}
-	}
 	result, err := publish.Publish(ctx, publish.Request{
 		RepositoryDir:    request.RepositoryDir,
 		Product:          request.Product,
 		Version:          request.Version,
 		Remote:           request.Remote,
-		AdditionalChecks: validate,
+		AdditionalChecks: candidateChecks(request.AdditionalChecks),
 		AfterValidate:    internalbuild.CandidateCallback(internalBuildSpec(request.Build), request.Output),
 		Output:           request.Output,
 	})