eric/ConfigKit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reuse document indexes for collection policy checks

Browse Source
This commit is contained in:
Eric Rakestraw
2026-10-24 14:17:09 +00:00
parent a0e5693d07
commit ea46001f78
4 changed files with 135 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
docs/roadmap/remediation.md
View File

@@ -1,8 +1,7 @@
# Sequence Implementation Review Remediation
Status: findings 1–17 are complete. The algorithm audit below identifies six
additional open findings, numbered 18–23. This record introduces no new release
gate.
Status: findings 1–23 are complete, including the six additional algorithm-audit
findings numbered 18–23. This record introduces no new release gate.
Reviewed commit: `0be7cdb00eff576fda6b30c0600b2134d4e2e086`.
Implementation range: `bc6b977..0be7cdb`.
@@ -40,6 +39,14 @@ ownership regressions; the contract corrections are verified against the
implemented operations and replay. Each additional finding has its own completion
record and commit.
Validation after algorithm remediation: `./scripts/check.sh` and
`go test -race ./...` pass with Go 1.26.10 on Linux. Focused regressions cover the
selector scope correction, sparse projection storage, broad CLI metadata,
inheritance policy localization/ownership, effective fallback locations, and
broad collection-policy lookups. Scaling conclusions follow from the revised
algorithms and structural coverage; no timing threshold or public performance
guarantee was added.
P1 denotes the highest-priority correctness issue here; P2 denotes normal-priority
work needed to complete the selected behavior. Preserve the agreed scope while
fixing these issues. In particular, do not resolve failures by restricting valid
@@ -919,7 +926,15 @@ or skip needed location attachment to avoid the work.
## 23. Index Repeated Collection-Policy Document Lookups — P2
Status: [ ] Open.
Status: [x] Complete.
Completion: overlay policy matching shares an immutable incoming-tree lookup;
declaration-only checks lazily index the completed result after merging.
Inheritance policy reconciliation shares one lookup over its stable parent and
child inputs. Added broad overlay/inheritance collections, retained and pending
declarations, escaped keys, ordered append, and origin coverage. Existing
retirement and diagnostic regressions, `./scripts/check.sh`, and the final
`go test -race ./...` pass.
Owners: `mergeOverlayMappingsWithCollectionPolicy` in
[`overlay.go`](../../internal/engine/overlay.go) and