Allow absent version headers below structural controls
This commit is contained in:
@@ -707,3 +707,14 @@ classification. Focused source-version/sensitivity/history tests,
|
||||
`GOTOOLCHAIN=local GOPROXY=off go test -race ./...` passed on
|
||||
`go1.26.9 linux/amd64`. Existing historical/dependency propagation and neighboring
|
||||
public-value coverage remain green; no new sensitivity policy was introduced.
|
||||
|
||||
Additional remediation regressions protect import opt-in
|
||||
(`TestFacadeSourceVersionModesPreserveImportOptIn`), complete absence paths
|
||||
(`TestSourceVersionAbsentPathKeepsUnresolvedSegmentIntent` and
|
||||
`TestFacadeSourceVersionAbsenceKeepsCompleteEvidencePath`), and optional missing
|
||||
headers below controls
|
||||
(`TestFacadeSourceVersionMissingHeaderDoesNotOverlapControl`). Each failed
|
||||
before its production correction and passes afterward. All four independent
|
||||
review probes, the final everyday check, and the full race suite now pass on
|
||||
`go1.26.9 linux/amd64`. The remediation record contains completion evidence;
|
||||
the agreed source-version policy and release gates are unchanged.
|
||||
|
||||
@@ -158,7 +158,8 @@ state. Main's local header is retained, accepted non-main headers are removed
|
||||
before placement/composition, and the destination-prefixed main rule reaches
|
||||
payload protection and typed conversion. Warnings, raw accounting, source
|
||||
contexts, and final loading reuse the existing pipeline. Four must-address
|
||||
issues remain. Findings 1 and 2 above remain completed historical findings.
|
||||
issues were identified and are now resolved below. Findings 1 and 2 above remain
|
||||
completed historical findings.
|
||||
|
||||
### 3. Preserve distinct semantic shapes during evidence classification (P1)
|
||||
|
||||
@@ -304,7 +305,15 @@ Required remediation:
|
||||
|
||||
### 6. Apply structural-overlap rejection only to an actual declaration (P2)
|
||||
|
||||
Status: open. This is an unintended strengthening of the agreed restriction.
|
||||
Status: complete. Overlap rejection now requires an actually present selected
|
||||
declaration. Optional absence proceeds without a non-main checker invocation;
|
||||
required absence and malformed controls still fail under their existing rules.
|
||||
The public regression failed before the fix and now covers valid inheritance
|
||||
in separate mounted scopes, required omission with NoSource main, and invalid
|
||||
inheritance controls. Existing present-overlap tests remain green. Focused
|
||||
source-version/directive/inheritance tests, the everyday check, and the full
|
||||
race suite passed on `go1.26.9 linux/amd64`. The configuration contract clarifies
|
||||
the omission boundary. This removes the unintended strengthened restriction.
|
||||
|
||||
Affected: `processSourceVersion` in
|
||||
[source_version.go](../../internal/engine/source_version.go), lines 197–219 at
|
||||
@@ -368,3 +377,16 @@ temporary directory.
|
||||
|
||||
No production fixes, repository regression tests, dependency updates, or release
|
||||
changes were made. Only this findings document was revised.
|
||||
|
||||
### Remediation completion validation
|
||||
|
||||
All four external review probes now pass against the corrected checkout,
|
||||
including both shape-collision acquisition orders. The final everyday check and
|
||||
`GOTOOLCHAIN=local GOPROXY=off go test -race ./...` passed on
|
||||
`go1.26.9 linux/amd64`. Each new regression was observed failing before its
|
||||
corresponding production fix.
|
||||
|
||||
The earlier completed Mapping diagnostic regression was rerun successfully, and
|
||||
ADR 0011 from `## Date` onward still matches its accepted text at `7248a8b`.
|
||||
No findings remain open. No dependencies, source-version policies, or release
|
||||
gates changed, and no release was published.
|
||||
|
||||
Reference in New Issue
Block a user