Complete ownership documentation and integration validation
This commit is contained in:
@@ -2,7 +2,8 @@
|
||||
|
||||
## Status and scope
|
||||
|
||||
Status: in progress; completed stages and their validation are recorded below.
|
||||
Status: complete; all nine stages are implemented and validated below.
|
||||
Release-candidate selection and publication remain separate maintainer work.
|
||||
Audit baseline: `9b147bfd96aec25e0125dcae66e136e56dc7a670`.
|
||||
|
||||
This roadmap owns the agreed maintainability cleanup before v0.1.0. It replaces
|
||||
@@ -56,8 +57,9 @@ Use focused existing behavioral tests during each stage and the baseline checks
|
||||
from the development guide before committing production changes. Add tests only
|
||||
for meaningful gaps exposed by extraction, not to enforce file locations or
|
||||
private call choreography. Update current owning documentation alongside each
|
||||
move. Planned filenames below are private implementation destinations, not new
|
||||
consumer contracts.
|
||||
move. The work lists below preserve the accepted scope; completion entries name
|
||||
the implemented owners. Audit-baseline evidence describes the original layout.
|
||||
Private implementation destinations are not new consumer contracts.
|
||||
|
||||
## Stage 1 — Remove unused overlay value snapshots
|
||||
|
||||
@@ -69,7 +71,7 @@ that resolution snapshots and history applications have separate live consumers;
|
||||
those and displaced origins remain intact. The full offline test suite, vet,
|
||||
build, and whitespace checks passed with Go 1.26.7 on Linux/amd64.
|
||||
|
||||
Evidence: `overlayRecord` in [overlay.go](../../overlay.go) retains `before` and
|
||||
Audit-baseline evidence: `overlayRecord` in [overlay.go](../../overlay.go) retains `before` and
|
||||
`after` trees; profile and CLI processing construct them and
|
||||
`cloneOverlayRecords` clones them. Production consumers use the record's change
|
||||
and displaced origins, while explanation uses `historyApplication` instead.
|
||||
@@ -100,7 +102,7 @@ safe selected-source errors and imported/profile source attribution, so no
|
||||
duplicate regression was added. Full offline tests, vet, build, and whitespace
|
||||
checks passed with Go 1.26.7 on Linux/amd64.
|
||||
|
||||
Evidence: [parse.go](../../parse.go) translates adapter issues inline, while
|
||||
Audit-baseline evidence: [parse.go](../../parse.go) translates adapter issues inline, while
|
||||
`importParseDiagnostics` in [imports.go](../../imports.go) repeats the translation
|
||||
for imports and profiles.
|
||||
|
||||
@@ -129,7 +131,7 @@ limit diagnostics. Existing filesystem, FIFO, budget, and reader tests pass;
|
||||
a private regression covers nondeterministic filesystem failure phases. Full
|
||||
offline baseline and race suites passed with Go 1.26.7 on Linux/amd64.
|
||||
|
||||
Evidence: `readSource`, `importTraversal.readImport`, and `readProfileFile` repeat
|
||||
Audit-baseline evidence: `readSource`, `importTraversal.readImport`, and `readProfileFile` repeat
|
||||
preflight stat, open, post-open stat, regular-file checks, size checks, and bounded
|
||||
reads in [source.go](../../source.go), [imports.go](../../imports.go), and
|
||||
[profile.go](../../profile.go).
|
||||
@@ -172,10 +174,10 @@ remain explicit. Full offline tests (including historical path shapes, metadata
|
||||
detachment, and dynamic secrets), vet, build, and whitespace checks passed with
|
||||
Go 1.26.7 on Linux/amd64.
|
||||
|
||||
Evidence: `indexDocument`, `walkDocumentPaths`, and `projectedSensitivity` repeat
|
||||
Audit-baseline evidence: `indexDocument`, `walkDocumentPaths`, and `projectedSensitivity` repeat
|
||||
semantic tree traversal in [load_metadata.go](../../load_metadata.go),
|
||||
[metadata.go](../../metadata.go), and [secret.go](../../secret.go). General document
|
||||
lookup currently lives in [load.go](../../load.go).
|
||||
lookup lived in [load.go](../../load.go).
|
||||
|
||||
Work:
|
||||
|
||||
@@ -215,7 +217,7 @@ Full offline baseline and race suites passed with Go 1.26.7 on Linux/amd64,
|
||||
including codec/cycle/limit, callback ownership, sensitivity, and secret-state
|
||||
regressions.
|
||||
|
||||
Evidence: [projection.go](../../projection.go) combines roughly 622 lines of
|
||||
Audit-baseline evidence: [projection.go](../../projection.go) combines roughly 622 lines of
|
||||
projection, detached cloning, dynamic schema handling, cycle/limit enforcement,
|
||||
and structural comparison. Value equality deliberately ignores sensitivity,
|
||||
which validation must check separately.
|
||||
@@ -260,7 +262,7 @@ preserves primary failures and explicitly checks the success-path close once.
|
||||
Full offline tests, vet, build, and whitespace checks passed with Go 1.26.7 on
|
||||
Linux/amd64, including imports/globs, profiles, CLI, limits, and provenance.
|
||||
|
||||
Evidence: [imports.go](../../imports.go) mixes filesystem context, directives,
|
||||
Audit-baseline evidence: [imports.go](../../imports.go) mixes filesystem context, directives,
|
||||
graph traversal, and diagnostics; [override.go](../../override.go) combines value
|
||||
construction/validation and application. Shared composition cloning is located
|
||||
inside the override feature, while profile overlay repeats it.
|
||||
@@ -304,7 +306,7 @@ clones remain, and publication adds no history copies. Full offline baseline and
|
||||
race suites passed with Go 1.26.7 on Linux/amd64; lifecycle, early-stop, warning,
|
||||
precedence, provenance, callback ownership, and secret tests passed unchanged.
|
||||
|
||||
Evidence: `loadWithSecretLookup` in [load.go](../../load.go) coordinates roughly
|
||||
Audit-baseline evidence: `loadWithSecretLookup` in [load.go](../../load.go) coordinates roughly
|
||||
200 lines of source assembly, decoding, callbacks, history, secrets, and result
|
||||
publication, including repeated creation of a composition handoff.
|
||||
|
||||
@@ -349,7 +351,7 @@ container/leaf, retained-budget, detachment, and writer-failure tests passed
|
||||
without expectation changes. Full offline tests, vet, build, and whitespace
|
||||
checks passed with Go 1.26.7 on Linux/amd64.
|
||||
|
||||
Evidence: [explain.go](../../explain.go) combines approximately 576 lines of public
|
||||
Audit-baseline evidence: [explain.go](../../explain.go) combines approximately 576 lines of public
|
||||
records, replay algorithms, snapshot redaction, retained-history accounting, and
|
||||
human-readable output.
|
||||
|
||||
@@ -376,7 +378,46 @@ leaf histories still reconcile with the frozen effective typed configuration.
|
||||
|
||||
## Stage 9 — Complete ownership documentation and integration validation
|
||||
|
||||
Status: pending.
|
||||
Status: complete.
|
||||
|
||||
Completion evidence (2026-09-07):
|
||||
|
||||
- Reviewed the final owners and accumulated diff against starting revision
|
||||
`874adaa`. Removed the unused `cloneResolutionSnapshots` helper and an unused
|
||||
resolution lookup binding; live resolution snapshots and replay budgets remain.
|
||||
Shared parser translation and document walking have one owner, while specialized
|
||||
origin, pruning, and shared-node accounting remain explicit.
|
||||
- Updated the [component overview](../internal/overview.md), repaired moved-owner
|
||||
navigation in the extraction and implementation records, and distinguished
|
||||
baseline findings from completion evidence here. The overview now accurately
|
||||
describes populated metadata queries and the retained dependency direction.
|
||||
- An independent Go AST comparison found all 186 root-package exported
|
||||
declarations unchanged from `874adaa`. Function-level review ignoring file moves
|
||||
matched the planned extractions, consolidation, and private renames. Existing
|
||||
behavioral assertions remain unchanged; no API, configuration, diagnostic,
|
||||
dependency, or consumer migration change was identified.
|
||||
- The complete source checker passed on native Linux/amd64 with CGO enabled,
|
||||
using these exact cached toolchains:
|
||||
|
||||
```sh
|
||||
CONFIGKIT_BASELINE_TOOLCHAIN=go1.25.5 CONFIGKIT_NEWER_TOOLCHAIN=go1.26.7 ./scripts/release-check.sh
|
||||
```
|
||||
|
||||
This ran offline default tests, vet, and native builds on Go 1.25.5 and Go 1.26.7;
|
||||
the full race suite on Go 1.26.7; disposable-copy module hygiene; formatting and
|
||||
whitespace; executable examples and consumer fixtures; local documentation
|
||||
links and the AST import-boundary gate; and CGO-disabled cross-builds for
|
||||
Linux/macOS on amd64/arm64. All passed; `go.mod` and `go.sum` are unchanged.
|
||||
- Fresh verbose Linux filesystem checks passed without skips for selected/imported/
|
||||
profile FIFO rejection, symlink containment, hard-link identity, optional missing
|
||||
targets, directory permission failures, and the new private read-failure phase
|
||||
regression. Package import inspection confirmed `internal/document` has no
|
||||
imports and only `internal/yaml` imports the upstream YAML package.
|
||||
- Native macOS and native arm64 execution were unavailable on this Linux/amd64
|
||||
host. Cross-builds do not close those execution gaps. Exact candidate validation,
|
||||
roadmap retirement, release-note review, remote/tag guards, and post-publication
|
||||
retrieval remain owned by the [release procedure](../release.md) and
|
||||
[readiness record](release-readiness.md). No tag, push, or publication occurred.
|
||||
|
||||
Work:
|
||||
|
||||
|
||||
Reference in New Issue
Block a user