Simplify release validation gates

release_check_test.go

@@ -123,8 +123,8 @@ func TestReleaseRunbookGuards(t *testing.T) {
 	}
 }
 
-func TestCheckScriptsHandleFilenamesAndStopOnFailure(t *testing.T) {
-	for _, scriptName := range []string{"release-check.sh", "check.sh"} {
+func TestDevelopmentCheckHandlesFilenamesAndStopsOnFailure(t *testing.T) {
+	for _, scriptName := range []string{"check.sh"} {
 		t.Run(scriptName, func(t *testing.T) {
 			script, err := os.ReadFile("scripts/" + scriptName)
 			if err != nil {
@@ -217,25 +217,95 @@ func TestCheckScriptsHandleFilenamesAndStopOnFailure(t *testing.T) {
 					if fail && strings.Contains(string(invoked), "vet ./...") {
 						t.Fatal("checker continued after failed test")
 					}
-					if scriptName == "release-check.sh" && !fail {
-						if strings.Count(string(invoked), " test ") != 1 || !strings.Contains(string(invoked), " test -race -v ./...\n") {
-							t.Fatalf("want one complete race-test run, got:\n%s", invoked)
-						}
-						if strings.Count(string(invoked), " vet ./...") != 1 || strings.Count(string(invoked), " build ./...") != 2 {
-							t.Fatalf("want one vet run and only two cross-builds, got:\n%s", invoked)
-						}
-						// These are selected release gates, not incidental loop details.
-						for _, target := range []string{"linux/amd64", "linux/arm64"} {
-							if !strings.Contains(string(invoked), target+" build ./...") {
-								t.Errorf("checker omitted required target %s", target)
-							}
-						}
-						if strings.Contains(string(invoked), "darwin/") {
-							t.Fatal("checker requires best-effort macOS validation")
-						}
-					}
 				})
 			}
 		})
 	}
 }
+
+func TestCheckScriptsReleaseGates(t *testing.T) {
+	script, err := os.ReadFile("scripts/release-check.sh")
+	if err != nil {
+		t.Fatal(err)
+	}
+	for _, scenario := range []string{"success", "failed-test", "missing-toolchain"} {
+		t.Run(scenario, func(t *testing.T) {
+			root := t.TempDir()
+			bin := t.TempDir()
+			for _, directory := range []string{"scripts", "nested"} {
+				if err := os.Mkdir(filepath.Join(root, directory), 0700); err != nil {
+					t.Fatal(err)
+				}
+			}
+			checker := filepath.Join(root, "scripts", "release-check.sh")
+			if err := os.WriteFile(checker, script, 0700); err != nil {
+				t.Fatal(err)
+			}
+			calls := filepath.Join(bin, "go.calls")
+			goStub := `#!/bin/sh
+printf '%s|%s|%s|%s|%s|%s\n' "$GOTOOLCHAIN" "$GOPROXY" "${CGO_ENABLED-}" "${GOOS-}" "${GOARCH-}" "$*" >> "$CONFIGKIT_TEST_GO_LOG"
+if [ "${CONFIGKIT_TEST_FAIL-}" = toolchain ] && [ "${1-}" = version ]; then exit 37; fi
+if [ "${CONFIGKIT_TEST_FAIL-}" = test ] && [ "${1-}" = test ]; then exit 37; fi
+`
+			if err := os.WriteFile(filepath.Join(bin, "go"), []byte(goStub), 0700); err != nil {
+				t.Fatal(err)
+			}
+			cmd := exec.Command("/bin/bash", checker)
+			cmd.Dir = filepath.Join(root, "nested")
+			cmd.Env = append(os.Environ(),
+				"PATH="+bin+string(os.PathListSeparator)+os.Getenv("PATH"),
+				"CONFIGKIT_BASELINE_TOOLCHAIN=test-baseline",
+				"CONFIGKIT_TEST_GO_LOG="+calls,
+				"GOOS=", "GOARCH=", "CGO_ENABLED=",
+			)
+			switch scenario {
+			case "failed-test":
+				cmd.Env = append(cmd.Env, "CONFIGKIT_TEST_FAIL=test")
+			case "missing-toolchain":
+				cmd.Env = append(cmd.Env, "CONFIGKIT_TEST_FAIL=toolchain")
+			}
+			output, err := cmd.CombinedOutput()
+			if scenario == "success" && err != nil {
+				t.Fatalf("checker: %v\n%s", err, output)
+			}
+			if scenario != "success" && err == nil {
+				t.Fatalf("checker accepted %s", scenario)
+			}
+			data, err := os.ReadFile(calls)
+			if err != nil {
+				t.Fatal(err)
+			}
+			lines := strings.Split(strings.TrimSpace(string(data)), "\n")
+			for _, line := range lines {
+				if !strings.HasPrefix(line, "test-baseline|off|") {
+					t.Fatalf("toolchain or offline setting lost: %q", line)
+				}
+			}
+			if scenario == "missing-toolchain" {
+				if len(lines) != 1 || !strings.HasSuffix(lines[0], "|version") {
+					t.Fatalf("checker ran after unavailable toolchain: %q", lines)
+				}
+				return
+			}
+			if len(lines) < 2 || lines[1] != "test-baseline|off||||test -mod=readonly -vet=off -race -v ./..." {
+				t.Fatalf("release suite command changed: %q", lines)
+			}
+			if scenario == "failed-test" {
+				if len(lines) != 2 {
+					t.Fatalf("checker continued after failure: %q", lines)
+				}
+				return
+			}
+			want := []string{
+				"test-baseline|off||||version",
+				"test-baseline|off||||test -mod=readonly -vet=off -race -v ./...",
+				"test-baseline|off||||vet -mod=readonly ./...",
+				"test-baseline|off|0|linux|amd64|build -mod=readonly ./...",
+				"test-baseline|off|0|linux|arm64|build -mod=readonly ./...",
+			}
+			if strings.Join(lines, "\n") != strings.Join(want, "\n") {
+				t.Fatalf("unexpected release gates:\n%s", data)
+			}
+		})
+	}
+}