Record relative import destination review findings
This commit is contained in:
@@ -1,4 +1,4 @@
|
|||||||
# Input destination review findings
|
# Destination review findings
|
||||||
|
|
||||||
Reviewed `d3d468a..945e111` against the approved
|
Reviewed `d3d468a..945e111` against the approved
|
||||||
[input-destinations roadmap](input-destinations.md),
|
[input-destinations roadmap](input-destinations.md),
|
||||||
@@ -88,3 +88,52 @@ Required remediation:
|
|||||||
instead of `/catalog/entries/item/bad` with `source.invalid`.
|
instead of `/catalog/entries/item/bad` with `source.invalid`.
|
||||||
- No production fixes or regression tests were added to this repository during
|
- No production fixes or regression tests were added to this repository during
|
||||||
the review. No performance measurements or new guarantees were inferred.
|
the review. No performance measurements or new guarantees were inferred.
|
||||||
|
|
||||||
|
## Relative import destination review (2026-10-14)
|
||||||
|
|
||||||
|
Reviewed `7248a8b..10edd95` against the
|
||||||
|
[relative-import roadmap](relative-import-destinations.md), completed
|
||||||
|
[implementation plan](implementation.md), and
|
||||||
|
[ADR 0012](../adr/0012-relative-import-destinations.md).
|
||||||
|
|
||||||
|
The implementation matches the selected architecture: literal string segments
|
||||||
|
append to each immediate parent's destination; placement uses the existing
|
||||||
|
strict-composition and final-loading pipeline; source records retain distinct
|
||||||
|
effective destinations without changing physical resource contexts. No runtime
|
||||||
|
defect, missing feature behavior, or unintended strengthening of consumer
|
||||||
|
contracts was identified. The completed input-destination finding above remains
|
||||||
|
resolved. One documentation correction remains.
|
||||||
|
|
||||||
|
### 2. Restore ADR 0011's accepted decision text (P3)
|
||||||
|
|
||||||
|
Status: open. Documentation only; no runtime correction is required.
|
||||||
|
|
||||||
|
Affected: [ADR 0011](../adr/0011-input-destinations.md), lines 34–42 at
|
||||||
|
`10edd95`. That commit rewrote its accepted Decision paragraph to incorporate
|
||||||
|
relative import destinations. Stage 1 of the implementation plan explicitly
|
||||||
|
required preserving that text, and the
|
||||||
|
[documentation policy](../policy/documentation.md#architecture-decision-records)
|
||||||
|
treats accepted decision content as immutable. Rewriting it obscures the original
|
||||||
|
decision and its subsequent extension, despite the accurate current behavior.
|
||||||
|
|
||||||
|
Required remediation:
|
||||||
|
|
||||||
|
- Restore that Decision paragraph verbatim from `7248a8b` (the same paragraph
|
||||||
|
remains unchanged at `a8beb3e`). Keep the extension link in ADR 0011's Status
|
||||||
|
section and retain ADR 0012 as the accepted extension record.
|
||||||
|
- Leave the implemented relative-import behavior and current configuration/API
|
||||||
|
documentation unchanged. No additional ADR or runtime tests are needed.
|
||||||
|
- Confirm the ADR 0011 diff against `7248a8b` changes only its Status section;
|
||||||
|
run the local documentation-link and whitespace checks.
|
||||||
|
|
||||||
|
### Relative import review validation
|
||||||
|
|
||||||
|
At `10edd95d4d9060bd46db51e0d6782c12dbda3120`, using
|
||||||
|
`go1.26.8 linux/amd64`, all of these passed:
|
||||||
|
|
||||||
|
- `GOTOOLCHAIN=local ./scripts/check.sh` (formatting, whitespace, tests,
|
||||||
|
examples, links, package boundaries, vet, and build).
|
||||||
|
- `GOTOOLCHAIN=local GOPROXY=off go test -race ./...`.
|
||||||
|
- `GOTOOLCHAIN=local GOPROXY=off go test -count=1 ./...`.
|
||||||
|
|
||||||
|
The review changed only this findings document; it did not implement fixes.
|
||||||
|
|||||||
Reference in New Issue
Block a user