Fix release destination handling and verification example
This commit is contained in:
@@ -180,10 +180,12 @@ Only when useful or requested, read back the remote tag or retrieve the exact
|
||||
version into a new module without a local `replace` directive. These checks
|
||||
are optional and non-gating. Do not poll CI or wait for module propagation.
|
||||
Private-host credentials must already be configured. For direct-origin
|
||||
verification, use a temporary consumer module and check the exact module path
|
||||
verification, set the version to the release just published (replace the sample
|
||||
below), then use a temporary consumer module and check the exact module path
|
||||
and version reported by `go list -m`:
|
||||
|
||||
```sh
|
||||
release_version=v0.5.0
|
||||
consumer_dir=$(mktemp -d)
|
||||
(
|
||||
cd "$consumer_dir"
|
||||
|
||||
@@ -1,5 +1,25 @@
|
||||
# Release Workflow Review Findings
|
||||
|
||||
Status: both findings addressed. The original findings below are retained as
|
||||
review history until normal release-preparation retirement.
|
||||
|
||||
## Resolution and verification
|
||||
|
||||
- Publication, fetch, and recovery now use the same validated named `origin`.
|
||||
Pushes retain exact refspecs and disabled implicit tags, and override the
|
||||
remote's mirror default for that invocation only. No new gate was introduced.
|
||||
- A disposable-Git regression failed against the original publisher and passes
|
||||
with the fix for normal publication and lost main/tag push responses. It also
|
||||
checks that broad push defaults do not publish or delete unrelated refs and
|
||||
that the rewrite destination receives no refs.
|
||||
- Optional consumer verification explicitly initializes the selected version.
|
||||
Executing the documented block with a local Go stub verified the exact module
|
||||
argument with both an initially unset and an initially stale version variable,
|
||||
without network retrieval.
|
||||
- Focused publication tests passed. Final validation passed: Bash syntax,
|
||||
whitespace review, and the Go 1.25.14 release checker (race suite including
|
||||
documentation links, full vet, and both Linux target builds).
|
||||
|
||||
Reviewed implementation through `3d0093e` against the release roadmap and
|
||||
completed implementation plan. The ordinary Go 1.25.14 release checker passed
|
||||
(offline race suite, full vet, Linux amd64/arm64 builds), as did Bash syntax
|
||||
|
||||
Reference in New Issue
Block a user