Reject validator changes to secret classification
This commit is contained in:
@@ -2,18 +2,18 @@
|
||||
|
||||
## Status and scope
|
||||
|
||||
Status: in progress. Review baseline: `f42ecc70c330a399aa6dada87658694402a515ec`.
|
||||
Status: complete. All nine findings have been addressed. Review baseline: `f42ecc70c330a399aa6dada87658694402a515ec`.
|
||||
This review covers the initial implementation against the
|
||||
[architecture policy](../policy/architecture.md), [configuration contract](../config.md),
|
||||
and [implementation plan](implementation.md). The package boundaries and principal
|
||||
lifecycle are in place, but the findings below must be addressed before claiming
|
||||
that the initial target is fully satisfied. No production code was changed during
|
||||
this review. All findings below were reproduced through the public API or local
|
||||
lifecycle were in place at review time; the original findings below are retained
|
||||
with completion evidence. No production code was changed during the original
|
||||
review; subsequent remediation is recorded here. All findings below were reproduced through the public API or local
|
||||
validation tools, with the additional affected call sites identified by inspection.
|
||||
|
||||
Priorities: P1 means high-impact confidentiality, isolation, or availability;
|
||||
P2 means a correctness or validation gap that also requires remediation.
|
||||
Each item remains open until its regression checks and the relevant baseline pass.
|
||||
Each item below records its completed correction and validation evidence.
|
||||
Keep current contracts and implementation evidence accurate when fixing these issues;
|
||||
do not change the agreed semantics simply to accommodate the implementation.
|
||||
|
||||
@@ -21,7 +21,10 @@ do not change the agreed semantics simply to accommodate the implementation.
|
||||
|
||||
Status: complete. Typed projections now retain concrete field sensitivity; final,
|
||||
baseline and pre-resolution projections feed historical/dependency classification.
|
||||
Dynamic nested, replaced, deleted and introduced-value regressions pass. Full tests
|
||||
Dynamic nested, replaced, deleted and introduced-value regressions pass. A final
|
||||
audit additionally verified that validators cannot change dynamic field sensitivity
|
||||
through equal-text type replacement; the added regression failed before the fix
|
||||
and now passes. Full tests
|
||||
pass with the temporary canonical-TMPDIR workaround for issue 8; vet, build and
|
||||
whitespace checks pass.
|
||||
|
||||
@@ -285,3 +288,24 @@ precedence, separate explicit bootstrap, and application-owned domain lifecycle
|
||||
remain appropriate. Repair these boundary and consistency defects within that
|
||||
architecture. Re-run focused regressions, the normal baseline and race suites,
|
||||
local documentation checks, and applicable release gates before closing this roadmap.
|
||||
|
||||
## Remediation completion
|
||||
|
||||
All nine findings are corrected and committed in individual units of work, with an
|
||||
additional issue-1 audit correction for validator sensitivity mutation. The normal
|
||||
macOS baseline no longer requires a TMPDIR workaround. The historical review and
|
||||
intermediate validation notes above retain the conditions that applied at the time.
|
||||
|
||||
The complete source checker is validated locally with:
|
||||
|
||||
```sh
|
||||
CONFIGKIT_BASELINE_TOOLCHAIN=go1.25.5 CONFIGKIT_NEWER_TOOLCHAIN=go1.26.0 /bin/bash scripts/release-check.sh
|
||||
```
|
||||
|
||||
This uses the available cached toolchains, runs both native baselines and the race
|
||||
suite, checks module hygiene, formatting, documentation and example boundaries,
|
||||
and cross-builds Linux/macOS on amd64/arm64. Native execution during remediation
|
||||
was macOS/arm64; new native Linux evidence and selection of current supported patch
|
||||
releases remain maintainer release gates. No release, tag, push or downstream
|
||||
application migration was performed. Retire this completed roadmap during release
|
||||
preparation according to the documentation policy.
|
||||
|
||||
Reference in New Issue
Block a user