eric/ConfigKit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Resolve native imports beneath nested roots

Browse Source
This commit is contained in:
Eric Rakestraw
2026-10-20 00:23:55 +00:00
parent 38fb315415
commit 75da54150f
3 changed files with 63 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
docs/roadmap/remediation.md
View File

@@ -1,6 +1,6 @@
# Import Discovery and Scheduling Review Findings
Status: in progress; issues 1–2 complete, four findings remain.
Status: in progress; issues 1–3 complete, three findings remain.
Reviewed implementation: `aa93aed..15943e2`, ending at
`15943e233ca3cd1286c03c0e7085871db344cd4b`, against the accepted
@@ -92,7 +92,7 @@ items, underlays, and selected main items, and failed before the change. The
full everyday check passed, including existing default/enabled source-version
and assigned-index ownership regressions.
## 3. [ ] P2 — Accept valid multi-component native filesystem roots
## 3. [x] P2 — Accept valid multi-component native filesystem roots
Owner: [resolveNativeImportPath](../../internal/engine/filesystem_links.go),
especially lines 170–181.
@@ -114,6 +114,12 @@ resolved targets. Test directory and glob discovery under multi-component roots,
with ordinary entries and supported symlinks. Do not require consumers to flatten
their roots or remove optional link-inspection capability.
Completed: native link resolution allows ancestor prefixes while resolving a
contained multi-component path; selected paths and resolved link targets still
undergo their existing containment checks. Public directory/glob regressions
cover ordinary and aliased roots plus escaping links. All four valid cases
failed before the fix. The full everyday check passed.
## 4. [ ] P2 — Distinguish finite symlink reuse from actual cycles
Owners: [resolveHostImportPath and resolveNativeImportPath](../../internal/engine/filesystem_links.go),