eric/ConfigKit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check canonical source paths correctly on macOS

Browse Source
This commit is contained in:
Eric Rakestraw
2026-09-06 19:13:16 -05:00
parent 3e70ad1285
commit 537d26e359
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
docs/roadmap/remediation.md
View File

@@ -215,6 +215,11 @@ continue to load, project, clone and classify correctly.
## 8. P2 — Fix the baseline test's canonical-path assumption on macOS ## 8. P2 — Fix the baseline test's canonical-path assumption on macOS
Status: complete. The source test compares canonical path identity and separately
checks the declared label. Full default and race suites pass on macOS/arm64 using
both the default TMPDIR and an intentionally symlinked TMPDIR. Vet, build and
whitespace checks also pass; no production canonicalization behavior changed.
Evidence: [source_test.go](../../source_test.go), Evidence: [source_test.go](../../source_test.go),
`TestFileSourcesReopenAndClassifyFailures`, compares `SourceInfo.Path` directly `TestFileSourcesReopenAndClassifyFailures`, compares `SourceInfo.Path` directly
with the path under `t.TempDir()`. Successful sources intentionally report a with the path under `t.TempDir()`. Successful sources intentionally report a

2
source_test.go
View File

@@ -52,7 +52,7 @@ func TestFileSourcesReopenAndClassifyFailures(t *testing.T) {
} }
source := File(path) source := File(path)
first, diagnostics := readSource(source, "source-1", defaultSourceLimits()) first, diagnostics := readSource(source, "source-1", defaultSourceLimits())
if len(diagnostics) != 0 || string(first.data) != "value: first\n" || first.info.Path != path { if len(diagnostics) != 0 || string(first.data) != "value: first\n" || first.info.Path != canonicalTestPath(t, path) || first.info.Label != path {
t.Fatalf("first read = %#v, %#v", first, diagnostics) t.Fatalf("first read = %#v, %#v", first, diagnostics)
} }
if err := os.WriteFile(path, []byte("value: second\n"), 0o600); err != nil { if err := os.WriteFile(path, []byte("value: second\n"), 0o600); err != nil {