eric/ConfigKit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Validate search filesystem context after selection

Browse Source
This commit is contained in:
Eric Rakestraw
2026-10-24 19:13:35 +00:00
parent f64497cb13
commit 4dc3e70877
3 changed files with 63 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
docs/roadmap/remediation.md
View File

@@ -1,6 +1,6 @@
# Configuration Discovery Review Findings
Status: five open findings. Implementation has not been changed by these reviews.
Status: finding 1 complete; findings 2–5 remain open.
Reviewed commit: `e50fee2`, including the discovery implementation commits after
`424c897`. The review compared the implementation with the
@@ -10,7 +10,13 @@ configuration and architecture contracts.
## 1. Defer Absence-Only Context Requirements Until The Search Outcome Is Known
Priority: P2. Status: open.
Priority: P2. Status: complete.
**Completed:** search prevalidation now defers absence-only root requirements
until selection. Ordinary, layered-main, and underlay regression cases compare
searched files with explicit files under an empty context and retain errors for
absent inputs. The regression failed before the fix. Focused context/absence
tests and `./scripts/check.sh` passed with Go 1.26.10 on Linux.
**Location:** [filesystem.go](../../internal/engine/filesystem.go), lines 77–123,
and the outcome-specific validation in