Remove unused reverse source conversions

This commit is contained in:
2026-10-25 12:50:11 +00:00
parent 455a4a355d
commit 19f5c2a2d5
6 changed files with 106 additions and 136 deletions

View File

@@ -1,6 +1,6 @@
# Consolidation Implementation Plan
Status: in progress. Stage 1 is complete; follow Stage 2 through Stage 20 in order.
Status: in progress. Stages 1 and 2 are complete; follow Stage 3 through Stage 20 in order.
The target executor is a Luna coding agent working through one end-to-end sprint.
## Authority, Baseline, And Execution
@@ -173,7 +173,7 @@ detached results and callback ownership (`internal/engine/metadata_test.go`,
coverage gap surfaced in this map; later focused checks remain assigned in the
validation groups above.
## Stage 2 — Remove Unused Reverse Bridges And Share Real Facade Conversion
## Stage 2 — Remove Unused Reverse Bridges And Share Real Facade Conversion (Complete)
**Owners:** root `conversion.go`, `records_test.go`, `lifecycle.go`, `layered.go`,
and engine `records.go`.
@@ -197,6 +197,12 @@ and engine `records.go`.
**Finish:** the unnecessary cross-package inverse interface is gone and real
conversion is shared without a new transport layer. Run F.
Progress notes (2026-10-25): removed the unused reverse source-record bridge
and engine setters, replaced synthetic round-trip fixtures with engine loads,
and shared override conversion across ordinary and layered options. Validation
group F passed with `GOTOOLCHAIN=local GOPROXY=off go test . -run
'SourceInfo|SourceVersionCheck|ImportSelection|Facade|PublicFacadeBoundary|DependencyImportBoundary' -count=1`.
## Stage 3 — Normalize Preflight Without Fabricated Options
**Owners:** engine `options.go`, ordinary entry in `load.go`, grouped entry in