eric/ConfigKit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Isolate user configuration discovery tests by platform

Browse Source
This commit is contained in:
Eric Rakestraw
2026-10-24 19:18:13 +00:00
parent 1ac1f8bc9e
commit 087050fa25
2 changed files with 30 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
docs/roadmap/remediation.md
View File

@@ -1,6 +1,6 @@
# Configuration Discovery Review Findings
Status: findings 1–2 complete; findings 3–5 remain open.
Status: findings 1–3 complete; findings 4–5 remain open.
Reviewed commit: `e50fee2`, including the discovery implementation commits after
`424c897`. The review compared the implementation with the
@@ -101,7 +101,15 @@ still produce no records. Revise the existing nil-primary assertion accordingly.
## 3. Isolate User-Configuration Preset Tests Using The Platform's Go Convention
Priority: P2. Status: open.
Priority: P2. Status: complete.
**Completed:** the environment-change test selects the environment variable used
by Go on Windows, macOS/iOS, Plan 9, or other Unix hosts, and obtains both fixture
bases through `os.UserConfigDir`. It remains nonparallel and restores the
environment. The redundant relative-XDG failure assumption was removed; existing
private-helper tests retain portable failure/short-circuit coverage. Focused
tests and `./scripts/check.sh` passed on Linux. The macOS branch was checked
against Go's helper implementation; no native macOS gate was added.
**Location:** [discovery_load_test.go](../../internal/engine/discovery_load_test.go),
`TestSearchSourceObservesUserConfigEnvironmentChanges`, lines 231–279.