Clarify when sequence identities are validated

This commit is contained in:
2026-10-17 04:55:32 +00:00
parent 8e3a0892d4
commit 008d2ba9c8
2 changed files with 27 additions and 3 deletions

View File

@@ -1,6 +1,7 @@
# Sequence Composition Review Remediation
Status: open. Reviewed implementation `2051177..0858af1`
Status: complete; all nine findings addressed in separate validated commits.
Reviewed implementation `2051177..0858af1`
(`0858af1029d07d93a5aa2e4f26cbec61fcfb3a51`) against the
[feature roadmap](sequence-composition.md), [implementation plan](implementation.md),
and accepted [ADR 0014](../adr/0014-sequence-placement-and-composition.md).
@@ -299,7 +300,11 @@ The recently added malformed-registered-record regression must continue to pass.
## 9. Correct the public identity-validation phase statement — P3
- [ ] Documentation corrected.
- [x] Documentation corrected.
Completion: the public declaration distinguishes registration preflight from
input identity validation during strict composition, matching the existing
configuration contract. The final everyday check and full race suite passed.
**Owner:** `Definition.SequenceCompositions` comment in
[lifecycle.go](../../lifecycle.go), line 20.
@@ -328,3 +333,21 @@ using disposable in-memory filesystems in a temporary Go program outside the
repository. The scaling finding is based on the inspected loops and lookup
implementation, not host timing. No production code, tests, dependencies,
release machinery, or downstream repositories were modified during this review.
## Remediation validation
All nine findings have completion evidence above. Final validation passed with
Go `go1.26.9 linux/amd64`:
- `GOTOOLCHAIN=local ./scripts/check.sh`
- `GOTOOLCHAIN=local GOPROXY=off go test -race ./...`
- Local documentation-link and whitespace checks.
The original external public-API reproductions were rerun against the completed
changes: consumed sensitive evidence is redacted, helper events are chronological
and source-specific, replacements explain removals, parsed/indexed version rules
agree, imported main-version claims fail, NoSource stays absent, and item conflict
paths identify the correct records. Static review and the wide-collection
regression verify the targeted lookup changes without adding performance
thresholds. No dependencies, public controls, release gates, or downstream
repositories were changed by remediation.