package nws

import (
	"encoding/json"
	"testing"
	"time"
)

func TestBuildForecastUsesShortForecastAsTextDescription(t *testing.T) {
	parsed := nwsForecastResponse{}
	parsed.Properties.GeneratedAt = "2026-03-16T18:00:00Z"
	parsed.Properties.Periods = []nwsForecastPeriod{
		{
			StartTime:        "2026-03-16T19:00:00Z",
			EndTime:          "2026-03-16T20:00:00Z",
			ShortForecast:    "  Mostly Cloudy  ",
			DetailedForecast: "Clouds increasing overnight.",
			Icon:             "https://example.invalid/icon",
		},
	}

	run, effectiveAt, err := buildForecast(parsed)
	if err != nil {
		t.Fatalf("buildForecast() error = %v", err)
	}
	if len(run.Periods) != 1 {
		t.Fatalf("periods len = %d, want 1", len(run.Periods))
	}
	if got, want := run.Periods[0].TextDescription, "Mostly Cloudy"; got != want {
		t.Fatalf("TextDescription = %q, want %q", got, want)
	}

	wantIssued := time.Date(2026, 3, 16, 18, 0, 0, 0, time.UTC)
	if !run.IssuedAt.Equal(wantIssued) {
		t.Fatalf("IssuedAt = %s, want %s", run.IssuedAt.Format(time.RFC3339), wantIssued.Format(time.RFC3339))
	}
	if !effectiveAt.Equal(wantIssued) {
		t.Fatalf("effectiveAt = %s, want %s", effectiveAt.Format(time.RFC3339), wantIssued.Format(time.RFC3339))
	}

	assertNoLegacyForecastDescriptionKeys(t, run.Periods[0])
}

func assertNoLegacyForecastDescriptionKeys(t *testing.T, period any) {
	t.Helper()

	b, err := json.Marshal(period)
	if err != nil {
		t.Fatalf("json.Marshal(period) error = %v", err)
	}
	var got map[string]any
	if err := json.Unmarshal(b, &got); err != nil {
		t.Fatalf("json.Unmarshal(period) error = %v", err)
	}

	for _, key := range []string{"conditionText", "providerRawDescription", "detailedText", "iconUrl"} {
		if _, ok := got[key]; ok {
			t.Fatalf("unexpected legacy key %q in marshaled period: %#v", key, got)
		}
	}
}