Commit Graph

12 Commits

Author SHA1 Message Date
f13f43cf56 refactor(providers): centralize provider-specific parsing and invariants
- Introduce internal/providers/nws with shared timestamp parsing used by both
  NWS sources and normalizers
- Migrate NWS observation source + normalizer to use the shared provider helper
  for consistent RFC3339/RFC3339Nano handling
- Introduce internal/providers/openweather with a shared URL invariant helper
  enforcing units=metric
- Remove duplicated OpenWeather URL validation logic from the observation source
- Align provider layering: move provider “contract/quirk” logic out of
  normalizers and into internal/providers
- Update normalizer and standards documentation to clearly distinguish:
  provider helpers (internal/providers) vs canonical mapping logic
  (internal/normalizers)

This refactor reduces duplication between sources and normalizers, clarifies
layering boundaries, and establishes a scalable pattern for future forecast
and alert implementations.
2026-01-15 20:40:53 -06:00
a341aee5df normalizers: Updated error handling within the JSON helper function. 2026-01-15 20:17:46 -06:00
1790218d38 Updated documentation for internal consistency. 2026-01-15 10:47:59 -06:00
84c4efbc2e normalizers/openweather: extract shared helpers into common.go
Refactor OpenWeather normalizers to improve structure and reuse by moving
provider-specific helper functions out of observation.go and into a new
common.go.

This keeps observation.go focused on schema matching and domain mapping,
preserves the “one normalizer per file” convention, and establishes a clear
home for helpers that will be shared by future OpenWeather forecast and alert
normalizers.

No functional behavior changes; this is a pure internal refactor.
2026-01-15 10:41:56 -06:00
8968b6bdcd Refactor normalizers: dedupe JSON decode + event finalize
Add shared normalizer helpers to centralize payload extraction, JSON decoding,
and event finalization/validation.

Refactor NWS, Open-Meteo, and OpenWeather observation normalizers to use the
shared spine, removing repeated boilerplate while preserving provider-specific
mapping logic.
2026-01-15 10:36:18 -06:00
e92577c30e Moved shared OpenMeteo time parsing code into a shared internal/providers/openmeteo library. 2026-01-15 10:17:56 -06:00
e28ff49201 Moved common HTTP body fetch code into a shared helper function. 2026-01-15 08:58:56 -06:00
b21ed856e9 Fixed an ordering bug in wmo_text.go. 2026-01-15 08:14:20 -06:00
f43babdfd2 openmeteo: refactored the OpenMeteo source files to relocate normalization logic to internal/normalizers. 2026-01-14 12:10:32 -06:00
759fa31762 openweather: refactored the OpenWeather source files to relocate normalization logic to internal/normalizers. 2026-01-14 11:59:17 -06:00
0ba2602bcc nws: refactored the NWS source files to relocate normalization logic to internal/normalizers. 2026-01-14 11:18:21 -06:00
efc44e8c6a normalizers: added a structure for normalizers; refactoring sources -> sources+normalizers is still todo. 2026-01-14 10:35:16 -06:00