Adopt shared configuration model in architecture and implementation plan
This commit is contained in:
@@ -180,6 +180,29 @@ rules and engine-capture path: load once, then hand off the result. Do not maint
|
||||
two independent implementations of configuration semantics. Existing source
|
||||
selection choices remain available subject to the accepted layout migration.
|
||||
|
||||
### Shared Configuration Data Model
|
||||
|
||||
**Accepted:** use one canonical set of configuration settings for the public API
|
||||
and internal configuration adapter, under the narrow exception in
|
||||
[ADR 0002](../adr/0002-shared-configuration-data-model.md) and the
|
||||
[architecture policy](../policy/architecture.md#shared-configuration-data-exception).
|
||||
Define the data types in a small internal package and expose them through root
|
||||
aliases such as `promptkit.Settings`. Include the nested settings and backend
|
||||
smoke/probe data types so both consumers and the adapter use the same declarations
|
||||
without an internal dependency on the root package.
|
||||
|
||||
Registration and resource capture use that model directly. Remove duplicate
|
||||
settings declarations and conversions that only copy equivalent fields between
|
||||
the facade and adapter. The benefit is simpler field maintenance and fewer
|
||||
opportunities for the two representations to diverge.
|
||||
|
||||
Source-building helpers retain their composition-oriented values. Runtime
|
||||
requests, execution objects, and resource reports retain their distinct
|
||||
representations and useful conversions. Preserve the ownership copies needed
|
||||
when capturing executable resources. Loading, normalization, validation, and
|
||||
execution behavior stay outside the shared data package. This is part of the
|
||||
current configuration migration, not a later facade-wide refactor.
|
||||
|
||||
### Fixed Section And Clean Migration
|
||||
|
||||
Move all PromptKit-owned document settings beneath `promptkit`, including
|
||||
@@ -321,9 +344,10 @@ and limits. This establishes feasibility, not completed production implementatio
|
||||
|
||||
The [implementation plan](implementation.md) owns the concrete API choices,
|
||||
ordered work, migration steps, and verification needed to reach this target.
|
||||
The shared configuration-model simplification remains a separate
|
||||
[future idea](future.md#shared-configuration-data-model), rather than a change to
|
||||
the architecture policy or this feature's scope.
|
||||
The prototype used separate public/internal settings and conversions; the
|
||||
accepted shared model replaces that experimental boundary arrangement. Its
|
||||
external-package decoding, registration, and capture paths will be verified
|
||||
during implementation alongside the existing ownership checks.
|
||||
|
||||
CommandKit and other consumers own their adapters and presentation. Their adoption
|
||||
is not a prerequisite for implementing PromptKit's resource, inspection, and
|
||||
|
||||
Reference in New Issue
Block a user