Omit inactive runtime schemas from prepared snapshots
This commit is contained in:
@@ -74,17 +74,33 @@ func TestPreparationRejectsInvalidOutputContractWithPublicError(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestInactiveSchemaDoesNotInterpretCyclicValue(t *testing.T) {
|
||||
func TestInactiveRuntimeSchemaIsNotRetained(t *testing.T) {
|
||||
cycle := map[string]any{}
|
||||
cycle["self"] = cycle
|
||||
engine := newSimpleEngine(t, "message")
|
||||
prepared, err := engine.Prepare(context.Background(), promptkit.RunRequest{PromptID: "prompt", Validation: &promptkit.OutputContract{Format: promptkit.FormatText, ValidationMode: promptkit.ValidationNone, Schema: cycle}})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
copy := prepared.OutputContract.Schema.(map[string]any)
|
||||
copy["self"].(map[string]any)["changed"] = true
|
||||
if copy["changed"] != true || cycle["changed"] != nil {
|
||||
t.Fatal("inactive schema copy shares caller storage")
|
||||
type schemaValue struct{ Properties map[string]any }
|
||||
original := schemaValue{Properties: map[string]any{"title": "original"}}
|
||||
for _, mode := range []promptkit.ValidationMode{promptkit.ValidationNone, promptkit.ValidationBasic, promptkit.ValidationJSON} {
|
||||
for _, value := range []any{original, cycle, make(chan int)} {
|
||||
request := promptkit.RunRequest{PromptID: "prompt", Validation: &promptkit.OutputContract{Format: promptkit.FormatText, ValidationMode: mode, Schema: value, SchemaPath: "ignored.json"}}
|
||||
prepared, err := engine.Prepare(context.Background(), request)
|
||||
if err != nil || prepared.OutputContract.Schema != nil || prepared.OutputContract.SchemaPath != "ignored.json" {
|
||||
t.Fatalf("prepare inactive %s schema: %+v, %v", mode, prepared, err)
|
||||
}
|
||||
handle, err := engine.PrepareExecution(context.Background(), request)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
original.Properties["title"] = "caller mutation"
|
||||
details := handle.Details()
|
||||
if details.OutputContract.Schema != nil {
|
||||
t.Fatal("inactive schema retained in details")
|
||||
}
|
||||
details.OutputContract.Schema = map[string]any{"title": "details mutation"}
|
||||
if handle.Details().OutputContract.Schema != nil {
|
||||
t.Fatal("details mutation changed retained state")
|
||||
}
|
||||
handle.Discard()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user