base-layer/commandkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Simplify typed input preparation

Browse Source
This commit is contained in:
Eric Rakestraw
2026-11-07 15:59:28 +00:00
parent b66a00da26
commit c4b5bcdbc2
6 changed files with 61 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
docs/roadmap/audit/catalog.md
View File

@@ -1,6 +1,6 @@
# Consolidated audit catalog
Status: **6 distinct open findings: 6 P3**, consolidated from 30
Status: **4 distinct open findings: 4 P3**, consolidated from 30
numbered entries in seven audit documents. Reviewed audit state:
`db732e3a1de55c844f77870e1c6db683c2685d5d`.
@@ -412,6 +412,10 @@ their purpose; no generic operation engine or rule registry is selected.
## F19 — P3: Typed input preparation mixes conversion, provenance, and replay assembly
**Complete.** Conversion-error attribution and operand preparation are extracted
without replacing flag ordering or replay. Focused conversion, occurrence,
capture and replay tests pass.
`prepareInputWithOccurrences` handles shape validation, conversion-error
spelling, occurrence identities, application order, required flags, operands,
and prepared callbacks. Captured binding replay depends on those shared
@@ -515,6 +519,10 @@ snapshot errors and operator-input validation.
## F24 — P3: Obsolete private production entry points remain for tests alone
**Complete.** Reporter selection/finalization, routed parsing and occurrence-aware
preparation replace the obsolete wrappers. Graph and text checks confirm their
removal; useful lifecycle and replay tests pass.
Legacy reporter setters/close, `App.parse`, and typed-preparation wrappers have
only test callers, while production uses current selection, finalization,
routed-session, and occurrence-aware paths. Some tests therefore exercise

9
docs/roadmap/implementation.md
View File

@@ -1,6 +1,6 @@
# Audit remediation implementation plan
Status: in progress; Stages 1–19 complete.
Status: in progress; Stages 1–20 complete.
Baseline: `d492c7747175c01a53261206c2b4356e53453621`. Before this sprint,
intervening changes recorded decisions and retired the completed older
@@ -629,6 +629,13 @@ Complete when each capture responsibility has a clear place and behavior holds.
## Stage 20 — Simplify typed preparation and retire remaining test wrappers
**Complete.** Conversion-error attribution and operand preparation are separate
private responsibilities (F19); obsolete reporter, parser and binding wrappers
are removed and test-only observation lives in tests (F24). Graph discovery and
text references confirmed the current occurrence-aware callers and absence of
the retired entry points. Focused binding, replay, occurrence, conversion, routed
parsing and reporter tests passed offline with Go 1.27.0 and `-mod=readonly`.
Findings: F19 and completion of F24. Sources: `binding.go`, `flag_values.go`,
`parser.go` and related tests; review reporter cleanup from stage 3 as well.