Preserve cancellation in aggregate smoke tests

This commit is contained in:
2026-11-07 15:36:23 +00:00
parent a806a9a62e
commit b66d265032
4 changed files with 98 additions and 7 deletions

View File

@@ -1,10 +1,10 @@
# Audit remediation implementation plan
Status: planned; no stage implemented by this document.
Status: in progress; Stage 1 complete.
Baseline: `d492c7747175c01a53261206c2b4356e53453621`. Source remains the audited
implementation; intervening changes recorded decisions and retired the completed
older remediation. The [roadmap](audit-remediation.md) owns the target and scope,
Baseline: `d492c7747175c01a53261206c2b4356e53453621`. Before this sprint,
intervening changes recorded decisions and retired the completed older
remediation. The [roadmap](audit-remediation.md) owns the target and scope,
the [catalog](audit/catalog.md) owns accepted decisions and finding status, and
its original audit links own defect evidence. The
[analysis](audit/remediation-analysis.md) explains the selected designs.
@@ -107,6 +107,13 @@ not converted into a passed check or a request for per-stage approval.
## Stage 1 — Retain aggregate smoke cancellation
**Complete.** The progress-delivery cancellation regression reproduced both
the false success and missing joined cause before the fix. The focused aligned
workspace checks passed: `go test -mod=readonly -run 'TestSmokeAggregate|TestSmokeTestCancellation' ./integrations/ckprompt`
with Go 1.27.0, `GOTOOLCHAIN=local`, and `GOPROXY=off`. Tests cover partial
results with and without a provider error, retained diagnostics and explanation,
omitted callbacks, and cancellation after the final check.
Findings: F01. Primary source: `integrations/ckprompt/smoke_command.go`.
1. In runSmokeAggregate, retain cancellation observed at the later checkpoint