Reject invalid legacy release selectors

This commit is contained in:
2026-11-04 02:29:09 +00:00
parent 12a6fa66fa
commit 7eac3fea65
3 changed files with 29 additions and 4 deletions

View File

@@ -1,6 +1,6 @@
# Release tooling review findings
Status: two open findings. Review baseline:
Status: R1 complete; R2 open. Review baseline:
`124a9fa57fb3f815bedbafe2d4819f6aa265ee7d`, covering the implementation commits
after `cb40f1d`. This record requests corrections; no implementation was changed
during review.
@@ -13,6 +13,13 @@ complete.
## R1 — P2: Reject raw helper command names as legacy module selectors
**Completed.** The legacy entry point now checks its three module selectors
before delegating to the helper, retaining the single profile/module mapping
there. Regression cases cover all three raw-command collisions and require
usage status 2 with no Go invocation. The new regression failed before the fix;
the complete focused scripts suite and shell syntax checks passed afterward
with Go 1.26.8, including valid legacy and direct raw-command forwarding.
**Location:** [scripts/release](../../scripts/release), lines 9–10, delegating to
the first-argument dispatch in [scripts/releasekit](../../scripts/releasekit),
lines 10–15. The invalid-form cases in