base-layer/commandkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Repair completion and reporting examples

Browse Source
This commit is contained in:
Eric Rakestraw
2026-11-07 15:43:59 +00:00
parent 4346b840db
commit 7c7d1df13f
5 changed files with 27 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
docs/roadmap/audit/catalog.md
View File

@@ -1,6 +1,6 @@
# Consolidated audit catalog
Status: **22 distinct open findings: 22 P3**, consolidated from 30
Status: **20 distinct open findings: 20 P3**, consolidated from 30
numbered entries in seven audit documents. Reviewed audit state:
`db732e3a1de55c844f77870e1c6db683c2685d5d`.
@@ -142,6 +142,10 @@ Also noted in the [documentation cross-references](13-documentation.md#previousl
## F06 — P3: The optional interactive completion consumer fails before shell validation
**Complete.** The renamed application-owned choice flag permits script
generation and the Bash interactive consumer and backend checks pass. Zsh and
Fish interactive checks remain unavailable because those shells are not installed.
The completion consumer fixture declares the reserved `format` flag, so App
construction fails before it can generate scripts or exercise interactive
completion. Default test suites skip this optional path.
@@ -169,6 +173,9 @@ through a reachable handle, not an unreachable heap leak.
## F08 — P3: The core example overwrites its optional argument default
**Complete.** The example assigns a scenario only when supplied; bare and
explicit demo invocations succeed and an invalid scenario returns usage status 2.
The example's scenario setter replaces the factory's `"demo"` default with an
unsupplied empty value. The ordinary `report` invocation consequently fails with
a usage error.

9
docs/roadmap/implementation.md
View File

@@ -1,6 +1,6 @@
# Audit remediation implementation plan
Status: in progress; Stages 1–5 complete.
Status: in progress; Stages 1–6 complete.
Baseline: `d492c7747175c01a53261206c2b4356e53453621`. Before this sprint,
intervening changes recorded decisions and retired the completed older
@@ -250,6 +250,13 @@ presentation failures remain separately observable.
## Stage 6 — Repair the maintained consumers
**Complete.** The fixture generates Bash, Zsh and Fish scripts; the available
interactive Bash backend and consumer checks passed. The full opt-in commands
reported failures for Zsh and Fish because those shells are not installed;
their interactive behavior remains unverified. The core example's bare and
explicit `demo` invocations succeeded, and an invalid scenario returned usage
status 2. Checks used Go 1.27.0 with offline, read-only module resolution.
Findings: F06 and F08. Sources: `testdata/completion/main.go`,
`completion_shell_test.go`, and `examples/core/main.go`.