Preserve configuration diagnostics from request builders

This commit is contained in:
2026-11-16 19:02:40 +00:00
parent 9b673d0485
commit 21dac4f89e
5 changed files with 115 additions and 25 deletions

View File

@@ -1,13 +1,22 @@
# Configuration outcome review remediation
Status — two open findings from the stage-by-stage review of
Status — R1 complete, R2 open. Findings from the stage-by-stage review of
[the implementation plan](implementation.md) at commit
`8a22dd6`. Review findings concern the accepted
[feature target](invalid-configuration-outcomes.md).
## R1 — Present ConfigKit diagnostics returned by request builders
Priority — P2. Status — open. Affects Stages 3 and 4.
Priority — P2. Status — complete. Affects Stages 3 and 4.
Completed by sharing ConfigKit loading-error diagnostic adaptation between engine
loaders and all three request builders. Public-command regression coverage now
checks malformed configuration, warnings and semantic rejection, ordinary builder
failures, cancellation, preserved causes, and skipped engine loading across
validation, preparation, individual smoke, and aggregate smoke. The regression
fails against the original adapters using a temporary Go overlay and passes with
the fix. All three aligned-workspace module suites and maintained examples passed
with Go 1.27.0, offline dependencies, and read-only module metadata.
### Relevant implementation